Integrated chai-subset and added assert-based negation to containSubset
#1664
+359
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
reviewed
Jan 18, 2025
43081j
reviewed
Jan 18, 2025
43081j
reviewed
Jan 18, 2025
Contributor
|
we should also add tests for using this with should and assert style assertions otherwise looks good so far though 👍 |
…bset PR Feedback
Contributor
Author
|
@43081j I'm not sure if it's necessary to run the full battery of tests in each assertion style - is it not enough to ensure that they actually call the right function, since all three styles ultimately just call the same |
Contributor
Author
|
Fixed merge conflict with the change in method of declaring aliases. Ready for re-review. |
43081j
approved these changes
Jan 23, 2025
Contributor
|
looks good to me 👍 big thanks for implementing this 🙏 |
Member
|
Thanks @BreadInvasion ❤️ |
8 tasks
8 tasks
nikku
referenced
this pull request
in camunda/camunda-modeler
Oct 6, 2025
should be removed after chai 5.2 is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A revival of @koddsson 's previous attempt at merging the abandoned
chai-subsetfunctionality, with some added comments and an assert-style negation of containSubset which was not present in the original package. I know there was some concern about code duplication in the original PR, so I'm happy to respond to feedback! Thanks all.Fixes #1616