-
Notifications
You must be signed in to change notification settings - Fork 30.5k
feat(chai): add containSubset assert aliases #72184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@BreadInvasion Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 72184,
"author": "BreadInvasion",
"headCommitOid": "876f56f5a0a74495e520a98c3d30023aa20fe704",
"mergeBaseOid": "e658654b3ed1389fdfb1ce6097ebe7329e3bee27",
"lastPushDate": "2025-03-12T16:45:21.000Z",
"lastActivityDate": "2025-03-24T15:28:14.000Z",
"mergeOfferDate": "2025-03-24T06:18:32.000Z",
"mergeRequestDate": "2025-03-24T15:28:14.000Z",
"mergeRequestUser": "BreadInvasion",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "chai",
"kind": "edit",
"files": [
{
"path": "types/chai/chai-tests.ts",
"kind": "test"
},
{
"path": "types/chai/index.d.ts",
"kind": "definition"
}
],
"owners": [
"Bartvds",
"AGBrown",
"olivr70",
"mwistrand",
"shaunluttin",
"micksatana",
"ErikSchierboom",
"bparan",
"CXuesong",
"joeykilpatrick"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "iisaduan",
"date": "2025-03-24T06:17:54.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2718502252,
"ciResult": "pass"
} |
|
🔔 @Bartvds @AGBrown @olivr70 @mwistrand @shaunluttin @micksatana @ErikSchierboom @bparan @CXuesong @joeykilpatrick — please review this PR in the next few days. Be sure to explicitly select |
|
Hi, would it be possible to get a review on this? It's been sitting for a bit. |
|
Re-ping @Bartvds, @AGBrown, @olivr70, @mwistrand, @shaunluttin, @micksatana, @ErikSchierboom, @bparan, @CXuesong, @joeykilpatrick: This PR has been out for over a week, yet I haven't seen any reviews. Could someone please give it some attention? Thanks! |
|
@BreadInvasion: Everything looks good here. I am ready to merge this PR (at 876f56f) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ (@Bartvds, @AGBrown, @olivr70, @mwistrand, @shaunluttin, @micksatana, @ErikSchierboom, @bparan, @CXuesong, @joeykilpatrick: you can do this too.) |
|
Ready to merge |
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If changing an existing definition:
chai-subsetand added assert-based negation to containSubset chaijs/chai#1664package.json.In the chai PR implementing
containSubsetinto the core package, I added aliasesassert.containsSubsetandassert.doesNotContainSubset, the former for semantic consistency with the rest of the package, and the latter due to a lack of an assert-based negation ofcontainSubset. These aliases are in the existing latest package,5.2.0.