Skip to content

Conversation

@BreadInvasion
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

In the chai PR implementing containSubset into the core package, I added aliases assert.containsSubset and assert.doesNotContainSubset, the former for semantic consistency with the rest of the package, and the latter due to a lack of an assert-based negation of containSubset. These aliases are in the existing latest package, 5.2.0.

@BreadInvasion BreadInvasion requested a review from Bartvds as a code owner March 12, 2025 16:45
@typescript-bot
Copy link
Contributor

typescript-bot commented Mar 12, 2025

@BreadInvasion Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 72184,
  "author": "BreadInvasion",
  "headCommitOid": "876f56f5a0a74495e520a98c3d30023aa20fe704",
  "mergeBaseOid": "e658654b3ed1389fdfb1ce6097ebe7329e3bee27",
  "lastPushDate": "2025-03-12T16:45:21.000Z",
  "lastActivityDate": "2025-03-24T15:28:14.000Z",
  "mergeOfferDate": "2025-03-24T06:18:32.000Z",
  "mergeRequestDate": "2025-03-24T15:28:14.000Z",
  "mergeRequestUser": "BreadInvasion",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "chai",
      "kind": "edit",
      "files": [
        {
          "path": "types/chai/chai-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/chai/index.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Bartvds",
        "AGBrown",
        "olivr70",
        "mwistrand",
        "shaunluttin",
        "micksatana",
        "ErikSchierboom",
        "bparan",
        "CXuesong",
        "joeykilpatrick"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "iisaduan",
      "date": "2025-03-24T06:17:54.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 2718502252,
  "ciResult": "pass"
}

@typescript-bot
Copy link
Contributor

🔔 @Bartvds @AGBrown @olivr70 @mwistrand @shaunluttin @micksatana @ErikSchierboom @bparan @CXuesong @joeykilpatrick — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this to Waiting for Code Reviews in Pull Request Status Board Mar 12, 2025
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Mar 12, 2025
@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Code Reviews in Pull Request Status Board Mar 12, 2025
@BreadInvasion
Copy link
Contributor Author

Formatting

The following files are not formatted:

1. types/chai/index.d.ts

2. types/chai/chai-tests.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against 64746e4

Force-pushed with formatting fixes - my bad for missing that!

@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Mar 12, 2025
@BreadInvasion
Copy link
Contributor Author

Hi, would it be possible to get a review on this? It's been sitting for a bit.

@typescript-bot
Copy link
Contributor

Re-ping @Bartvds, @AGBrown, @olivr70, @mwistrand, @shaunluttin, @micksatana, @ErikSchierboom, @bparan, @CXuesong, @joeykilpatrick:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Mar 23, 2025
@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Mar 24, 2025
@typescript-bot
Copy link
Contributor

@BreadInvasion: Everything looks good here. I am ready to merge this PR (at 876f56f) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@Bartvds, @AGBrown, @olivr70, @mwistrand, @shaunluttin, @micksatana, @ErikSchierboom, @bparan, @CXuesong, @joeykilpatrick: you can do this too.)

@typescript-bot typescript-bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Mar 24, 2025
@BreadInvasion
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Mar 24, 2025
@typescript-bot typescript-bot merged commit ea8444a into DefinitelyTyped:master Mar 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Critical package Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants