Variable Naming and Function Doc

BreadInvasion · BreadInvasion · commit 9f48750866e3 · 2025-01-22T17:00:28.000-06:00
diff --git a/lib/chai/core/assertions.js b/lib/chai/core/assertions.js
@@ -4068,7 +4068,7 @@ Assertion.addProperty('finite', function (_msg) {
  *
  * @param {unknown} expected
  * @param {unknown} actual
- * @returns {void}
+ * @returns {boolean}
  */
 function compareSubset(expected, actual) {
   if (expected === actual) {
@@ -4104,15 +4104,19 @@ function compareSubset(expected, actual) {
   }
 
   return Object.keys(expected).every(function (key) {
-    var eo = expected[key];
-    var ao = actual[key];
-    if (typeof eo === 'object' && eo !== null && ao !== null) {
-      return compareSubset(eo, ao);
+    var expectedValue = expected[key];
+    var actualValue = actual[key];
+    if (
+      typeof expectedValue === 'object' &&
+      expectedValue !== null &&
+      actualValue !== null
+    ) {
+      return compareSubset(expectedValue, actualValue);
     }
-    if (typeof eo === 'function') {
-      return eo(ao);
+    if (typeof expectedValue === 'function') {
+      return expectedValue(actualValue);
     }
-    return ao === eo;
+    return actualValue === expectedValue;
   });
 }
 
