Skip to content

upgrade to Python 3.13 and Debian Trixie #13037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 18, 2025
Merged

upgrade to Python 3.13 and Debian Trixie #13037

merged 8 commits into from
Sep 18, 2025

Conversation

@dfangl
Copy link
Member

@dfangl dfangl commented Aug 20, 2025 •
edited
Loading

Motivation

This PR updates the base image to debian trixie, and the python version to python 3.13.

This has several advantages:

  1. More modern python version
  2. Less CVEs detected due to up-to-date dependencies (not all fixes get backported)
  3. Generally more up-to-date software

However, this might also lead to certain breakages:

  1. Newer debian version will deprecate certain commands, like apt-key. For more information, see here: https://www.debian.org/releases/trixie/release-notes/issues.en.html#obsolescence-and-deprecation

  2. Removal of certain, already deprecated, python functionality. For more information on this, see here:
    Python 3.12: https://docs.python.org/3.12/whatsnew/3.12.html#removed
    Python 3.13: https://docs.python.org/3.13/whatsnew/3.13.html#removed-modules-and-apis

Changes

  • Upgrade to python 3.13 and debian trixie
  • Init script calls will now have the script name (correctly) as first argument
  • Increased unit test timeouts

@dfangl dfangl added this to the Playground milestone Aug 20, 2025
@dfangl dfangl added the semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases label Aug 20, 2025
@github-actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 172 tests  ±0   20 434 ✅ ±0   15m 18s ⏱️ + 8m 42s
     1 suites ±0    1 738 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 069bf64. ± Comparison against base commit 329a337.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 58m 2s ⏱️ -5s
4 673 tests ±0  4 342 ✅ ±0  331 💤 ±0  0 ❌ ±0 
4 675 runs  ±0  4 342 ✅ ±0  333 💤 ±0  0 ❌ ±0 

Results for commit 069bf64. ± Comparison against base commit 329a337.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed mentioned this pull request Aug 21, 2025
Closed
3 tasks
@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch from 915891b to 8c1965a Compare August 21, 2025 13:42
@alexrashed alexrashed added the docs: skip Pull request does not require documentation changes label Aug 21, 2025
@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

S3 Image Test Results (AMD64 / ARM64)

    2 files  ±0    2 suites  ±0   8m 25s ⏱️ +15s
  532 tests ±0  480 ✅ ±0   52 💤 ±0  0 ❌ ±0 
1 064 runs  ±0  960 ✅ ±0  104 💤 ±0  0 ❌ ±0 

Results for commit 069bf64. ± Comparison against base commit 329a337.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Helper Script Tests

34 tests   34 ✅  0s ⏱️
 2 suites   0 💤
 1 files     0 ❌

Results for commit 069bf64.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Test Results (MA/MR) - Preflight, Unit

22 172 tests   20 434 ✅  15m 52s ⏱️
     1 suites   1 738 💤
     1 files         0 ❌

Results for commit 069bf64.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Test Results (amd64, MA/MR) - Acceptance

7 tests   5 ✅  3m 24s ⏱️
1 suites  2 💤
1 files    0 ❌

Results for commit 069bf64.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 37s ⏱️ -2s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 069bf64. ± Comparison against base commit 329a337.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 36m 12s ⏱️
5 047 tests 4 556 ✅ 491 💤 0 ❌
5 053 runs  4 556 ✅ 497 💤 0 ❌

Results for commit 069bf64.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch from 417b69f to e396178 Compare August 22, 2025 06:25
@github-actions
Copy link

github-actions bot commented Aug 22, 2025 •
edited
Loading

Test Results (amd64, MA/MR) - Integration, Bootstrap

    5 files      5 suites   2h 35m 47s ⏱️
5 047 tests 4 556 ✅ 491 💤 0 ❌
5 053 runs  4 556 ✅ 497 💤 0 ❌

Results for commit 069bf64.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Aug 22, 2025 •
edited
Loading

Coverage Status

coverage: 82.637% (-4.2%) from 86.843%
when pulling e396178 on python-3-13-trixie-upgrade-pro
into ac189fe on main.

@alexrashed
Copy link
Member

alexrashed commented Aug 22, 2025

This run is already looking pretty good, I triggered a full run to see if there's anything there are any issues in tests that are currently skipped (+ARM): https://github.com/localstack/localstack/actions/runs/17149129206

@github-actions
Copy link

github-actions bot commented Aug 22, 2025 •
edited
Loading

Test Results (arm64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 28s ⏱️ +8s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 069bf64. ± Comparison against base commit 329a337.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Aug 22, 2025 •
edited
Loading

Test Results (arm64) - Integration

    4 files      4 suites   2h 31m 3s ⏱️
5 023 tests 4 531 ✅ 492 💤 0 ❌
5 029 runs  4 531 ✅ 498 💤 0 ❌

Results for commit 069bf64.

♻️ This comment has been updated with latest results.

@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch 3 times, most recently from 0143076 to c8c3952 Compare September 1, 2025 13:31
@dfangl dfangl force-pushed the python-3-13-trixie-upgrade-pro branch from c8c3952 to 83ba996 Compare September 2, 2025 07:41
@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch from 83ba996 to 9c95fcc Compare September 3, 2025 12:37
@alexrashed alexrashed modified the milestones: Playground, 4.9 Sep 3, 2025
@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch from 9c95fcc to e331032 Compare September 4, 2025 07:49
@alexrashed alexrashed changed the title Upgrade to python3.13 and debian trixie Upgrade to Python 3.13 and Debian Trixie Sep 4, 2025
@alexrashed alexrashed changed the title Upgrade to Python 3.13 and Debian Trixie upgrade to Python 3.13 and Debian Trixie Sep 4, 2025
@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch from e331032 to f6d019c Compare September 10, 2025 07:09
@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch from 1b90d96 to c5ef1f8 Compare September 17, 2025 12:10
@localstack localstack deleted a comment from localstack-bot Sep 17, 2025
@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch from c5ef1f8 to 58a5036 Compare September 17, 2025 13:30
@alexrashed alexrashed marked this pull request as ready for review September 17, 2025 17:09
@alexrashed alexrashed force-pushed the python-3-13-trixie-upgrade-pro branch from 58a5036 to 069bf64 Compare September 18, 2025 09:13
alexrashed
alexrashed approved these changes Sep 18, 2025
View reviewed changes
Copy link
Member

@alexrashed alexrashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the great team work on upgrading Python and Debian! This will really help us to keep up to date with the language and the OS, allowing us to use all those cool new language features, and get rid of a lot of CVEs in the image! 💯

@alexrashed
Copy link
Member

alexrashed commented Sep 18, 2025

FYI: Here's a full run (including ARM) just to make sure we don't break something unexpected.

@dfangl dfangl merged commit 524c3ae into main Sep 18, 2025
105 checks passed
@dfangl dfangl deleted the python-3-13-trixie-upgrade-pro branch September 18, 2025 10:53
@alexrashed alexrashed mentioned this pull request Sep 18, 2025
Merged
@simonrw simonrw mentioned this pull request Sep 18, 2025
Closed
This was referenced Sep 23, 2025
Merged
Merged
Merged
@alexrashed alexrashed added the notes: needed Pull request should be mentioned in the release notes label Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexrashed alexrashed alexrashed approved these changes

@bentsku bentsku Awaiting requested review from bentsku bentsku is a code owner

@k-a-il k-a-il Awaiting requested review from k-a-il k-a-il is a code owner

@thrau thrau Awaiting requested review from thrau thrau is a code owner

@silv-io silv-io Awaiting requested review from silv-io silv-io is a code owner

@sannya-singal sannya-singal Awaiting requested review from sannya-singal sannya-singal is a code owner

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

Assignees

No one assigned

Labels

docs: skip Pull request does not require documentation changes notes: needed Pull request should be mentioned in the release notes semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

4 participants

@dfangl @coveralls @alexrashed