Update dev scripts to assume python 3.13 #13164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results - Preflight, Unit22 172 tests ±0 20 434 ✅ ±0 16m 31s ⏱️ +15s Results for commit 1f467f2c. ± Comparison against base commit 74a088f. |
Test Results (amd64) - Acceptance7 tests ±0 5 ✅ ±0 3m 21s ⏱️ -7s Results for commit 1f467f2c. ± Comparison against base commit 74a088f. |
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 35m 31s ⏱️ Results for commit 1f467f2c. |
LocalStack Community integration with Pro 2 files ±0 2 suites ±0 1h 59m 37s ⏱️ + 1m 52s Results for commit 1f467f2c. ± Comparison against base commit 74a088f. |
Contributor
Author
|
Closing as a duplicate of #13163 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #13037 we updated to Python 3.13 (🎉) however we missed updating a couple of dev scripts. These overwrite the venv site-packages path in a running pro container/pod and as such need to use the correct path.
Changes
Swap 3.11 for 3.13
Testing
Run
python -m localstack.dev.runwith the pro image with a code change and it should be picked up. Without this PR the code change is not picked up.