-
Notifications
You must be signed in to change notification settings - Fork 83
[DX Waterfall] QSY behaviour #2491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You may want to change the base branch to dev here? |
|
just checked this from user-perspective in a quick-run. things found so far:
|
phl0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested various stations on different bands (without CAT-controlled TRX) and could not spot any issues.
phl0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After carefully re-checking with @int2001 I can confirm his issue. Preparing a log and changing band does not update wkd/not wkd status where as mode change does.
|
Mentioned issue was fixed, but... the code was massively refactored - some of the code was moved to Downside - again, massive piece of code for the review. 😞 Important NoteAs the code was refactored in all possible aspects, please consider it UNTESTED - whatever was tested/was working in the past, may not be working now and new bugs might be introduced. I tried my best to test it, but it's massive piece of code. |
Quick fix for PRs #2491 2479 merge
Summary
Refactored DX Waterfall from bidirectional coupling (form ↔ radio ↔ waterfall) to unidirectional data flow (Radio → CAT → catState → Waterfall/Form), eliminating race conditions and simplifying the codebase.
This shall address:
Problem Statement
The original implementation had bidirectional coupling between form, radio, and waterfall components, causing:
Solution
Implemented unidirectional data flow with radio as the single source of truth: