Don't clear on Bandchange! #2487
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That's tricky - then we will again run into a troubles discussed in #2476 This is issue with the architecture, not only code. Please see #2485 (comment) |
Contributor
Author
|
we need a solution b4 our next release here. current situation is not good / ready 4 release |
Contributor
|
I double that. This has to be resolved. The DX Waterfall has way too much impact on the form data which is the most important thing. Clearing users formdata must not happen except in really special and carefully considered cases. There is no way around |
Contributor
|
I would say, let's cancel this PR - more complex update to come within: #2491 |
szporwolik
added a commit
to szporwolik/wavelog
that referenced
this pull request
Nov 5, 2025
Contributor
Author
|
i'll leave this PR open for now, since it mitigates things "for now" (not perfect, but it works for the moment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People are complaining that complete form is cleared on Bandchange.
This never happened before, but since #2429
This one reverts that logic. Please have a look if something at the new Cluster fails @szporwolik