Use autorelease check instead of custom script
#1173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1173 +/- ##
==========================================
- Coverage 81.51% 81.51% -0.01%
==========================================
Files 147 147
Lines 15806 15806
==========================================
- Hits 12885 12884 -1
- Misses 2921 2922 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
autorelease check instead of customs scriptautorelease check instead of custom script
Member
Author
|
This is ready for review and comment. Without review, I will merge this after at least 24 hours, no sooner than Mon 12 May 21:00 GMT (16:00 my local). |
autorelease check instead of custom scriptautorelease check instead of custom script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently bumped up to setuptools 80 in our default builds. This is causing problems because of major changes in how
setuptoolstreats thedevelopcommand.In any case, instead of having a custom script that uses autorelease, it is better to use the
autorelease checkcommand, available since autorelease 0.3.0 (2021). That's what this PR will do.autorelease checkfixes (otherwise, fix might be needed upstream in autorelease)devtools/autorelease_check.py