Skip to content

CFN: add support for passing objects in GetAtt #13206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

CFN: add support for passing objects in GetAtt #13206

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb3ae56
CFN: add support for passing objects in GetAtt
pinzon Sep 29, 2025
d61f59d
comment type validation
pinzon Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions localstack-core/localstack/services/cloudformation/engine/v2/change_set_model_preproc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,10 +274,10 @@ def _deployed_property_value_of(
property_value: Any | None = get_value_from_path(properties, property_name)

if property_value:
if not isinstance(property_value, (str, list)):
# TODO: is this correct? If there is a bug in the logic here, it's probably
# better to know about it with a clear error message than to receive some form
# of message about trying to use a dictionary in place of a string
if not isinstance(property_value, (str, list, dict)):
# Str: Standard expected type. TODO validate bools and numbers
# List: Multiple resource types can return a list of values e.g. AWS::EC2::VPC.
# Dict: Custom resources in CloudFormation can return arbitrary data structures.
raise RuntimeError(
f"Accessing property '{property_name}' from '{resource_logical_id}' resulted in a non-string value nor list"
)
Expand Down
Loading