Skip to content

CFN: add support for passing objects in GetAtt #13206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2025
Merged

CFN: add support for passing objects in GetAtt #13206

merged 2 commits into from
Oct 8, 2025

Conversation

@pinzon
Copy link
Member

@pinzon pinzon commented Sep 29, 2025 •
edited
Loading

Motivation

This PR enables Fn::GetAtt to return objects (e.g., nested or structured data) as values, a feature primarily used by CDK utilities like the JSON generator. This is critical for complex CDK constructs that rely on downstream resources expecting well-defined object structures.

Changes

  • Enable Fn::GetAtt to pass objects as values.

Testing

  • Since this is required for Custom Resources, the test is added in another repository.

@github-actions
Copy link

github-actions bot commented Sep 29, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 292 tests  ±0   20 549 ✅ ±0   15m 39s ⏱️ ±0s
     1 suites ±0    1 743 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit d61f59d. ± Comparison against base commit b592fbd.

♻️ This comment has been updated with latest results.

@pinzon pinzon added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases aws:cloudformation:v2 Issues related to the V2 CloudFormation engine docs: skip Pull request does not require documentation changes labels Sep 29, 2025
@pinzon pinzon added this to the Playground milestone Sep 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 29, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 23s ⏱️ -1s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit d61f59d. ± Comparison against base commit b592fbd.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 29, 2025 •
edited
Loading

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   34m 44s ⏱️ - 1h 26m 3s
576 tests  - 4 226  461 ✅  - 4 003  115 💤  - 223  0 ❌ ±0 
578 runs   - 4 226  461 ✅  - 4 003  117 💤  - 223  0 ❌ ±0 

Results for commit d61f59d. ± Comparison against base commit b592fbd.

This pull request removes 4226 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

♻️ This comment has been updated with latest results.

@pinzon pinzon added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 29, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

  5 files    5 suites   48m 14s ⏱️
600 tests 486 ✅ 114 💤 0 ❌
606 runs  486 ✅ 120 💤 0 ❌

Results for commit d61f59d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Sep 29, 2025 •
edited
Loading

Test Results - Alternative Providers

575 tests   330 ✅  25m 44s ⏱️
  1 suites  245 💤
  1 files      0 ❌

Results for commit d61f59d.

♻️ This comment has been updated with latest results.

@pinzon pinzon marked this pull request as ready for review September 29, 2025 19:45
dominikschubert
dominikschubert requested changes Oct 2, 2025
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change request, then good to go 👍

@dominikschubert dominikschubert self-requested a review October 2, 2025 17:42
dominikschubert
dominikschubert approved these changes Oct 2, 2025
View reviewed changes
Copy link
Member

@dominikschubert dominikschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing my comment by adding additional documentation on the allowed property types 👍

@pinzon pinzon force-pushed the cp/cfn/iam-resource-provider branch from bff5621 to d61f59d Compare October 7, 2025 19:48
@pinzon pinzon merged commit 0943c36 into main Oct 8, 2025
41 checks passed
@pinzon pinzon deleted the cp/cfn/iam-resource-provider branch October 8, 2025 17:44
baermat pushed a commit that referenced this pull request Oct 13, 2025
@pinzon @baermat
CFN: add support for passing objects in GetAtt (#13206)
eec5754
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dominikschubert dominikschubert dominikschubert approved these changes

@simonrw simonrw Awaiting requested review from simonrw simonrw is a code owner

Assignees

No one assigned

Labels

aws:cloudformation:v2 Issues related to the V2 CloudFormation engine aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

Playground

Development

Successfully merging this pull request may close these issues.

3 participants

@pinzon @dominikschubert