Skip to content

CloudWatch: fix MA/MR for new snapshot test test_put_metric_alarm_escape_character #13190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

CloudWatch: fix MA/MR for new snapshot test test_put_metric_alarm_escape_character #13190

merged 1 commit into from
Sep 24, 2025

Conversation

@bentsku
Copy link
Contributor

@bentsku bentsku commented Sep 24, 2025

Motivation

Follow up from #13173

It added snapshots for a few tests, but I missed that one region was hardcoded in some field.

This PR updates it to use the region from the client for proper transformation.

Changes

  • update test to use region_name instead of hardcoded value

@bentsku bentsku added this to the 4.9 milestone Sep 24, 2025
@bentsku bentsku self-assigned this Sep 24, 2025
@bentsku bentsku added aws:cloudfront Amazon CloudFront area: multi-account Multi-tenancy in LocalStack semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes labels Sep 24, 2025
@alexrashed alexrashed added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 24, 2025
@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Test Results - Preflight, Unit

22 269 tests  ±0   20 528 ✅ ±0   15m 40s ⏱️ -15s
     1 suites ±0    1 741 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 60d5c57. ± Comparison against base commit f7ffe66.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 21s ⏱️ +3s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 60d5c57. ± Comparison against base commit f7ffe66.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Test Results - Alternative Providers

180 tests    39 ✅  2m 33s ⏱️
  1 suites  141 💤
  1 files      0 ❌

Results for commit 60d5c57.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   42m 27s ⏱️ - 1h 16m 50s
1 173 tests  - 3 608  1 097 ✅  - 3 348  76 💤  - 260  0 ❌ ±0 
1 175 runs   - 3 608  1 097 ✅  - 3 348  78 💤  - 260  0 ❌ ±0 

Results for commit 60d5c57. ± Comparison against base commit f7ffe66.

This pull request removes 3608 tests. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   59m 6s ⏱️
1 197 tests 1 123 ✅ 74 💤 0 ❌
1 203 runs  1 123 ✅ 80 💤 0 ❌

Results for commit 60d5c57.

pinzon
pinzon approved these changes Sep 24, 2025
View reviewed changes
Copy link
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix 👍

@bentsku bentsku merged commit 15fc427 into main Sep 24, 2025
58 checks passed
@bentsku bentsku deleted the cloudwatch-fix-ma-mr branch September 24, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pinzon pinzon pinzon approved these changes

@steffyP steffyP Awaiting requested review from steffyP steffyP is a code owner

Assignees

@bentsku bentsku

Labels

area: multi-account Multi-tenancy in LocalStack aws:cloudfront Amazon CloudFront docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

4 participants

@bentsku @pinzon @alexrashed