Skip to content

CloudWatch: fix MA/MR for new snapshot test test_put_metric_alarm_escape_character #13190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2025
Merged

CloudWatch: fix MA/MR for new snapshot test test_put_metric_alarm_escape_character #13190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/aws/services/cloudwatch/test_cloudwatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,7 +837,9 @@ def _count_metrics_in_namespace_with_dimension_value():
@markers.snapshot.skip_snapshot_verify(
condition=is_old_provider, paths=["$..MetricAlarms..StateTransitionedTimestamp"]
)
def test_put_metric_alarm_escape_character(self, cleanups, aws_cloudwatch_client, snapshot):
def test_put_metric_alarm_escape_character(
self, cleanups, aws_cloudwatch_client, snapshot, region_name
):
snapshot.add_transformers_list(
[
snapshot.transform.key_value("AlarmName"),
Expand All @@ -856,7 +858,7 @@ def test_put_metric_alarm_escape_character(self, cleanups, aws_cloudwatch_client
Threshold=1,
ComparisonOperator="GreaterThanThreshold",
EvaluationPeriods=1,
AlarmActions=["arn:aws:sns:us-east-1:111122223333:MyTopic"],
AlarmActions=[f"arn:aws:sns:{region_name}:111122223333:MyTopic"],
)
cleanups.append(lambda: aws_cloudwatch_client.delete_alarms(AlarmNames=["cpu-mon"]))

Expand Down
6 changes: 3 additions & 3 deletions tests/aws/services/cloudwatch/test_cloudwatch.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@
}
},
"tests/aws/services/cloudwatch/test_cloudwatch.py::TestCloudwatch::test_put_metric_alarm_escape_character[query]": {
"recorded-date": "19-09-2025, 20:51:19",
"recorded-date": "24-09-2025, 15:16:44",
"recorded-content": {
"describe-alarms-escaped-character": {
"CompositeAlarms": [],
Expand Down Expand Up @@ -1317,7 +1317,7 @@
}
},
"tests/aws/services/cloudwatch/test_cloudwatch.py::TestCloudwatch::test_put_metric_alarm_escape_character[json]": {
"recorded-date": "19-09-2025, 20:51:19",
"recorded-date": "24-09-2025, 15:16:45",
"recorded-content": {
"describe-alarms-escaped-character": {
"CompositeAlarms": [],
Expand Down Expand Up @@ -1355,7 +1355,7 @@
}
},
"tests/aws/services/cloudwatch/test_cloudwatch.py::TestCloudwatch::test_put_metric_alarm_escape_character[smithy-rpc-v2-cbor]": {
"recorded-date": "19-09-2025, 20:51:20",
"recorded-date": "24-09-2025, 15:16:46",
"recorded-content": {
"describe-alarms-escaped-character": {
"CompositeAlarms": [],
Expand Down
24 changes: 12 additions & 12 deletions tests/aws/services/cloudwatch/test_cloudwatch.validation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,30 +1326,30 @@
}
},
"tests/aws/services/cloudwatch/test_cloudwatch.py::TestCloudwatch::test_put_metric_alarm_escape_character[json]": {
"last_validated_date": "2025-09-19T20:51:20+00:00",
"last_validated_date": "2025-09-24T15:16:45+00:00",
"durations_in_seconds": {
"setup": 0.0,
"call": 0.32,
"teardown": 0.26,
"total": 0.58
"call": 0.4,
"teardown": 0.34,
"total": 0.74
}
},
"tests/aws/services/cloudwatch/test_cloudwatch.py::TestCloudwatch::test_put_metric_alarm_escape_character[query]": {
"last_validated_date": "2025-09-19T20:51:19+00:00",
"last_validated_date": "2025-09-24T15:16:45+00:00",
"durations_in_seconds": {
"setup": 0.49,
"call": 0.68,
"teardown": 0.22,
"total": 1.39
"call": 0.71,
"teardown": 0.23,
"total": 1.43
}
},
"tests/aws/services/cloudwatch/test_cloudwatch.py::TestCloudwatch::test_put_metric_alarm_escape_character[smithy-rpc-v2-cbor]": {
"last_validated_date": "2025-09-19T20:51:20+00:00",
"last_validated_date": "2025-09-24T15:16:46+00:00",
"durations_in_seconds": {
"setup": 0.0,
"call": 0.34,
"teardown": 0.21,
"total": 0.55
"call": 0.31,
"teardown": 0.23,
"total": 0.54
}
},
"tests/aws/services/cloudwatch/test_cloudwatch.py::TestCloudwatch::test_put_metric_data_validation[json]": {
Expand Down
Loading