Skip to content

src/goImpl: improve goimpl implememtations (#1547) #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
day-dreams wants to merge 9 commits into
base: master
Choose a base branch
from
+76 −13,785
Open

src/goImpl: improve goimpl implememtations (#1547) #1592

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c2e17a3
Improve goimpl implememtations (#1547)
day-dreams Jun 25, 2021
3cd9332
src/goImpl.ts: improve goimp implementations
day-dreams Jun 26, 2021
3c9d035
Merge branch 'golang:master' into master
day-dreams Jul 26, 2021
f2bd27a
Merge branch 'master' into pr1592
hyangah Dec 29, 2021
4776a3d
.vscode/launch.json: recover launch.json
hyangah Dec 29, 2021
368a049
src/goImpl: remove unnecessary replacement
hyangah Dec 29, 2021
6994d90
package.json: npm install lodash
hyangah Dec 30, 2021
b2f06cc
src/goImpl: use quickpick description and handle symbol with .
hyangah Dec 30, 2021
11dd0ec
typings/lodash.d.ts: remove ancient copy of lodash.d.ts
hyangah Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into pr1592 
Change-Id: I7e26f492e584088a5e06d12d46561038d1069914
  • Loading branch information
@hyangah
hyangah committed Dec 29, 2021
commit f2bd27aae826fbd72133420885cb51a825a742a4
6 changes: 4 additions & 2 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@
"999999"
],
"env": {
"VSCODE_GO_IN_TEST": "1" // Disable code that shouldn't be used in test
"VSCODE_GO_IN_TEST": "1", // Disable code that shouldn't be used in test
"MOCHA_TIMEOUT": "999999",
},
"stopOnEntry": false,
"sourceMaps": true,
Expand All @@ -87,7 +88,8 @@
"999999",
],
"env": {
"VSCODE_GO_IN_TEST": "1" // Disable code that shouldn't be used in test
"VSCODE_GO_IN_TEST": "1", // Disable code that shouldn't be used in test
"MOCHA_TIMEOUT": "999999"
},
"stopOnEntry": false,
"sourceMaps": true,
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/goImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ export function implCursor() {

quickPick.onDidChangeValue(lodash.debounce(search, 250));

quickPick.onDidChangeSelection((selections: vscode.QuickPickItem[]) => {
quickPick.onDidChangeSelection((selections: readonly vscode.QuickPickItem[]) => {
if (typeof selections === 'undefined') {
return;
}
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.