Skip to content

src/goImpl: improve goimpl implememtations (#1547) #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
day-dreams wants to merge 9 commits into
base: master
Choose a base branch
from
+76 −13,785
Open

src/goImpl: improve goimpl implememtations (#1547) #1592

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c2e17a3
Improve goimpl implememtations (#1547)
day-dreams Jun 25, 2021
3cd9332
src/goImpl.ts: improve goimp implementations
day-dreams Jun 26, 2021
3c9d035
Merge branch 'golang:master' into master
day-dreams Jul 26, 2021
f2bd27a
Merge branch 'master' into pr1592
hyangah Dec 29, 2021
4776a3d
.vscode/launch.json: recover launch.json
hyangah Dec 29, 2021
368a049
src/goImpl: remove unnecessary replacement
hyangah Dec 29, 2021
6994d90
package.json: npm install lodash
hyangah Dec 30, 2021
b2f06cc
src/goImpl: use quickpick description and handle symbol with .
hyangah Dec 30, 2021
11dd0ec
typings/lodash.d.ts: remove ancient copy of lodash.d.ts
hyangah Dec 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src/goImpl: use quickpick description and handle symbol with . 
If user searches with 'io.Reader' for more specific workspace
symbol search, the new interface returns 'io.Reader' as the
symbol name. Passing it to impl as it is will cause an error.
Use only the part after '.' as a heuristic.

Change-Id: I7935ad9ef59be50db0bc09890b9532c8e0ba32b6
  • Loading branch information
@hyangah
hyangah committed Dec 30, 2021
commit b2f06cc602c756e40e2416b1183be72e8c722445
12 changes: 6 additions & 6 deletions src/goImpl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@ import vscode = require('vscode');

class InterfaceItem implements vscode.QuickPickItem {
public label: string;
public description: string;
public name: string;
public package: string;
public location: vscode.Location;

constructor(public symbol: vscode.SymbolInformation) {
this.label = symbol.name + ' ' + symbol.containerName;
this.name = symbol.name;
constructor(symbol: vscode.SymbolInformation) {
this.label = symbol.name;
this.description = symbol.containerName;
this.name = symbol.name.split('.').pop(); // in case, symbol contains package name.
this.package = symbol.containerName;
this.location = symbol.location;
}
}

Expand All @@ -37,7 +37,7 @@ export function implCursor() {
}
const cursor = editor.selection;
const quickPick = vscode.window.createQuickPick();
quickPick.placeholder = 'Input interface name (e.g. client)';
quickPick.placeholder = 'Input interface name (e.g. Client)';

const search = function (keyword: string) {
quickPick.busy = true;
Expand Down