Fix handling of multi-message TSIG responses #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #300 +/- ##
============================================
+ Coverage 64.18% 65.53% +1.34%
- Complexity 2765 2834 +69
============================================
Files 178 184 +6
Lines 12546 12724 +178
Branches 1915 1944 +29
============================================
+ Hits 8053 8339 +286
+ Misses 4002 3876 -126
- Partials 491 509 +18
☔ View full report in Codecov by Sentry. |
Contributor
|
I'm afraid its not quite right. In this case, there is still a bug with verify process (and a symmetric bug with the generate process). The signature of the TSIG record isn't being added at quite the right time (as usual only in the case of mixed signed/unsigned messages). On the bright side, the bug is much more narrow at this point. I've got a branch of 'tsig-stream' I'll submit shortly as another PR. |
Co-authored-by: Frank Hill <frank@arin.net>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #295
Closes #297
Closes #298
Closes #299
Closes #301