Skip to content

Conversation

@frankarinnet
Copy link
Contributor

This pull request is in reference to: #295

As requested, this PR targets the 3.5.x branch. It obseletes #296.

From the old PR:

There are still some TODOs, however, because I need some guidance on how to deal with thread safety in the TSIG.

So, don't merge this without commenting.

and

I've created: https://github.com/frankarinnet/axfr

Which might be helpful for testing this. It was the simplest program I could write to demonstrate this bug for manual testing.

But you will still need to:

    set up a DNS server
    with TSIG
    that allows full zone transfers (AXFR)
    configured with a few different-sized zones

For zone sizes, I've been using:

    a small zone (with 8 lines)
    a medium zone (with 8k lines)
    a large zone (with 160k lines)

ibauersachs added a commit that referenced this pull request Oct 29, 2023
Closes #295
Closes #297
Closes #298
Closes #299

Co-authored-by: Frank Hill <frank@arin.net>
Co-authored-by: Nick Guichon <nickg@arin.net>
ibauersachs added a commit that referenced this pull request Nov 4, 2023
* Fix handling of multi-message TSIG responses

Closes #295
Closes #297
Closes #298
Closes #299
Closes #301

Co-authored-by: Frank Hill <frank@arin.net>
Co-authored-by: Nick Guichon <nickg@arin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants