Path filters: include deleted files in changed-file detection (Fixes #26356) #26540

tcolvin2006 · 2025-11-29T03:10:37Z

Fixes #26356 — Adds a minimal opt-in option to the changed-files action so the path-filters composite will receive deleted files (allowing CI decisions to consider removals), while all other consumers (including the markdown link verifier) keep the existing behavior; this change is intentionally small and low-risk.

…-changed-files

Copilot

Pull request overview

This PR addresses issue #26356 by adding an opt-in include-deleted parameter to the get-changed-files action, enabling the path-filters composite action to consider deleted files when making CI decisions. The implementation follows a backward-compatible approach where the parameter defaults to false, preserving existing behavior for all current consumers (markdown link verifier and merge conflict checker) while allowing the path-filters action to opt-in by setting it to true.

Key changes:

Added include-deleted boolean input parameter to get-changed-files action with default value of false
Updated file filtering logic to include removed status files when the parameter is enabled, consistently across both pull_request and push event handlers
Enabled the new parameter (include-deleted: 'true') in the path-filters action to detect when files are deleted in relevant directories

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`.github/actions/infrastructure/get-changed-files/action.yml`	Added `include-deleted` input parameter and updated filtering logic to conditionally include removed files in both PR and push event handlers
`.github/actions/infrastructure/get-changed-files/README.md`	Updated documentation to describe the new parameter and clarify that deleted files are filtered out by default unless opted-in
`.github/actions/infrastructure/path-filters/action.yml`	Enabled `include-deleted: 'true'` to receive deleted files for path filtering decisions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-29T03:12:56Z

.github/actions/infrastructure/get-changed-files/action.yml

        script: |
          const eventTypes = '${{ inputs.event-types }}'.split(',').map(t => t.trim());
          const filter = '${{ inputs.filter }}';
+          const includeDeleted = ('${{ inputs.include-deleted }}' || 'false').toLowerCase() === 'true';


[nitpick] The expression ('${{ inputs.include-deleted }}' || 'false') will not work as intended when the input is an empty string. In JavaScript, an empty string '' is falsy, so ('' || 'false') evaluates to 'false'. However, when the input is explicitly provided as an empty string, this could lead to unexpected behavior.

Consider simplifying to:

const includeDeleted = '${{ inputs.include-deleted }}'.toLowerCase() === 'true';

This works correctly because:

When not provided or empty: ''.toLowerCase() === 'true' → false ✓

When 'false': 'false'.toLowerCase() === 'true' → false ✓

When 'true': 'true'.toLowerCase() === 'true' → true ✓

The current code works, but the || 'false' is unnecessary since the default is already set in the action input definition.

Suggested change

const includeDeleted = ('${{ inputs.include-deleted }}' || 'false').toLowerCase() === 'true';

const includeDeleted = '${{ inputs.include-deleted }}'.toLowerCase() === 'true';

Copilot · 2025-11-29T03:12:57Z

.github/actions/infrastructure/get-changed-files/README.md

 |------|-------------|----------|---------|
 | `filter` | Optional filter pattern (e.g., `*.md` for markdown files, `.github/` for GitHub files) | No | `''` |
 | `event-types` | Comma-separated list of event types to support (`pull_request`, `push`) | No | `pull_request` |
+| `include-deleted` | Include deleted/removed files in the results (`true`/`false`) | No | `false` |


[nitpick] Consider adding a usage example in the "Usage" section demonstrating the include-deleted parameter. Since this is a new feature, showing how to use it would improve discoverability.

For example:

# Include deleted files in the results (useful for CI decisions) - name: Get all changed files including deletions id: changed-files uses: "./.github/actions/infrastructure/get-changed-files" with: include-deleted: 'true'

While the parameter is documented in the inputs table, a concrete usage example would clarify when and how to use this opt-in feature.

microsoft-github-policy-service · 2025-12-06T07:33:19Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

microsoft-github-policy-service · 2025-12-06T07:33:28Z

@tcolvin2006 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

Definitions.
“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to Microsoft under this Agreement.
“Project” means any of the projects owned or managed by Microsoft and offered under a license
approved by the Open Source Initiative (www.opensource.org).
“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”
“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.
Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.
Originality of Work. You represent that each of Your Submissions is entirely Your original work.
Should You wish to Submit materials that are not Your original work, You may Submit them separately
to the Project if You (a) retain all copyright and license information that was in the materials as You
received them, (b) in the description accompanying Your Submission, include the phrase “Submission
containing materials of a third party:” followed by the names of the third party and any licenses or other
restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
guidelines concerning Submissions.
Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.
Licenses.

Copyright License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
parties.
Patent License. You grant Microsoft, and those who receive the Submission directly or
indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.
Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
You later become aware that would make Your representations in this Agreement inaccurate in any
respect.
Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.
Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.
Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

path-filters: include deleted files; add include-deleted input to get…

afc2e71

…-changed-files

Copilot AI review requested due to automatic review settings November 29, 2025 03:10

tcolvin2006 requested review from a team and jshigetomi as code owners November 29, 2025 03:10

Copilot started reviewing on behalf of tcolvin2006 November 29, 2025 03:11 View session

Copilot finished reviewing on behalf of tcolvin2006 November 29, 2025 03:12

Copilot AI reviewed Nov 29, 2025

View reviewed changes

microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Dec 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Path filters: include deleted files in changed-file detection (Fixes #26356) #26540

Path filters: include deleted files in changed-file detection (Fixes #26356) #26540

Uh oh!

tcolvin2006 commented Nov 29, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 29, 2025

Uh oh!

Copilot AI Nov 29, 2025

Uh oh!

microsoft-github-policy-service bot commented Dec 6, 2025

Uh oh!

microsoft-github-policy-service bot commented Dec 6, 2025

Contribution License Agreement

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	const includeDeleted = ('${{ inputs.include-deleted }}' \|\| 'false').toLowerCase() === 'true';
	const includeDeleted = '${{ inputs.include-deleted }}'.toLowerCase() === 'true';

Path filters: include deleted files in changed-file detection (Fixes #26356) #26540

Are you sure you want to change the base?

Path filters: include deleted files in changed-file detection (Fixes #26356) #26540

Uh oh!

Conversation

tcolvin2006 commented Nov 29, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

microsoft-github-policy-service bot commented Dec 6, 2025

Uh oh!

microsoft-github-policy-service bot commented Dec 6, 2025

Contribution License Agreement

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant