Conversion to use ImageSharp rather than System.Drawing.Common#658
Merged
GregorBiswanger merged 1 commit intoElectronNET:masterfrom Apr 6, 2022
Merged
Conversation
…ng.Common for cross platform compatibility. Breaking Changes: * `System.Drawing.Common` is dropped and `SixLabors.ImageSharp` is introduced. * uses of `NativeImage.CreateFromBitmap(bitmap, options);` is no longer supported, will cause failed builds. Unexpected Behaviors: * uses ToDataUrl will always create png data urls, unexpected output may happen for those that manipulate this output expecting a different data url format. Obsoletions: * `CreateFromBitmapOptions` & `CreateFromBufferOptions` have been consolidated into `CreateOptions`. Implicit conversions added to ease transition. * `ToBitmapOptions`, `ToDataUrlOptions`, `ToPngOptions` & `BitmapOptions` have been consolidated into `ImageOptions`. Implicit conversions added to ease transition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #637 Conversion to use ImageSharp rather than System.Drawing.Common for cross platform compatibility.
Breaking Changes:
System.Drawing.Commonis dropped andSixLabors.ImageSharpis introduced.NativeImage.CreateFromBitmap(bitmap, options);is no longer supported, will cause failed builds.Unexpected Behaviors:
ToDataUrlwill always create png data urls, unexpected output may happen for those that manipulate this output expecting a different data url format.Obsoletions:
CreateFromBitmapOptions&CreateFromBufferOptionshave been consolidated intoCreateOptions. Implicit conversions added to ease transition.ToBitmapOptions,ToDataUrlOptions,ToPngOptions&BitmapOptionshave been consolidated intoImageOptions. Implicit conversions added to ease transition.