Updates all the way to 19.0.8 by theolivenbaum · Pull Request #681 · ElectronNET/Electron.NET

theolivenbaum · 2022-04-07T04:19:20Z

Hi @GregorBiswanger , just saw that you merged my other PR.

If you want, here are the remaining changes I've done since then - lots of fixes, updates, etc...

(like X:0 on browser view set bounds)

…to handler instead

This reverts commit 4e7cebe.

…message

…quest

GregorBiswanger · 2022-06-27T17:25:54Z

I would like to merge your pull requests.. can you please check the conflicted ones.

GregorBiswanger · 2022-07-12T14:25:16Z

@theolivenbaum I would like to merge your pull requests.. can you please check the conflicted ones.

theolivenbaum · 2022-07-12T17:31:23Z

Hi @GregorBiswanger - I unfortunately don't have the bandwidth right now to review this changes - specially to make sure this doesn't introduce any new issues due to the big changes I added on our fork to be async-only. I'm keeping our fork of ElectronNet up to date with Electron releases and I think it would be awesome to merge this back to the main repo, but I can't commit on the work for that right now. Maybe someone from the community could take over the work?

…oses)

lafleurh · 2022-07-26T15:13:48Z

@GregorBiswanger Let me know what help you need bringing this in. We are looking to update our branch and contribute some WiX stuff back. I am not able to build or run the latest code.

GregorBiswanger · 2022-07-26T18:07:00Z

@lafleurh There are some merge conflicts. I only have a few weeks time.

GregorBiswanger · 2022-07-28T09:54:05Z

@theolivenbaum I merged all and the project should build without problems. I don´t know why you implement the SocketIO source directly?! I was think, you wont to use the nuge library?! Please check the current merged version on our repo.. Thanks!

GregorBiswanger · 2022-07-28T10:23:16Z

@theolivenbaum I get the following exception when running a new "Hello World" project.

I had installed the Nito.AsyncEx.Coordination Library via NuGet at the API project. Why do we need this dependency? Can you do without?

electron.cmd "..\..\main.js"

Electron Socket IO Port: 8000
Electron Socket started on port 8000 at 127.0.0.1
.NET Core Port: 8001
stderr: Unhandled exception.
stderr: Unhandled exception.
stderr: System.TypeInitializationException: The type initializer for 'ElectronNET.API.BridgeConnector' threw an exception.
 ---> System.IO.FileNotFoundException: Could not load file or assembly 'Nito.AsyncEx.Coordination, Version=5.1.2.0, Culture=neutral, PublicKeyToken=null'. Das System kann die angegebene Datei nicht finden.
File name: 'Nito.AsyncEx.Coordination, Version=5.1.2.0, Culture=neutral, PublicKeyToken=null'
   at ElectronNET.API.BridgeConnector..cctor()
   --- End of inner exception stack trace ---
   at ElectronNET.API.BridgeConnector.get_Logger() in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\BridgeConnector.cs:line 536
   at ElectronNET.API.BridgeConnector.Log(String formatString, Object[] args) in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\BridgeConnector.cs:line 396
   at ElectronNET.API.WebHostBuilderExtensions.UseElectron(IWebHostBuilder builder, String[] args) in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\WebHostBuilderExtensions.cs:line 26
   at Program.<Main>$(String[] args) in C:\Users\Gregor\source\repos\ElectronNetNewTest\Program.cs:line 5
   at Program.<Main>(String[] args)

stderr: System.TypeInitializationException: The type initializer for 'ElectronNET.API.BridgeConnector' threw an exception.
 ---> System.IO.FileNotFoundException: Could not load file or assembly 'Nito.AsyncEx.Coordination, Version=5.1.2.0, Culture=neutral, PublicKeyToken=null'. Das System kann die angegebene Datei nicht finden.
File name: 'Nito.AsyncEx.Coordination, Version=5.1.2.0, Culture=neutral, PublicKeyToken=null'
   at ElectronNET.API.BridgeConnector..cctor()
   --- End of inner exception stack trace ---
   at ElectronNET.API.BridgeConnector.get_Logger() in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\BridgeConnector.cs:line 536
   at ElectronNET.API.BridgeConnector.Log(String formatString, Object[] args) in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\BridgeConnector.cs:line 396
   at ElectronNET.API.WebHostBuilderExtensions.UseElectron(IWebHostBuilder builder, String[] args) in C:\Users\Gregor\source\repos\Electron.NET\ElectronNET.API\WebHostBuilderExtensions.cs:line 26
   at Program.<Main>$(String[] args) in C:\Users\Gregor\source\repos\ElectronNetNewTest\Program.cs:line 5
   at Program.<Main>(String[] args)

.NET process exited with code 3762504530
Will quit Electron, as exit code != 0 (got 3762504530)

GregorBiswanger · 2022-10-03T09:42:51Z

@theolivenbaum Can you please see the error message. ☝️

lafleurh · 2022-10-03T15:39:06Z

I managed to get it working for us. See https://github.com/evoleap/Electron.NET/tree/master19 bit I'm waiting on another project and we have some breaking changes to rectify. Also, we went to .net 6.

theolivenbaum added 30 commits August 26, 2021 08:40

fix for socket not being thread-safe

2f02292

Use ILogger instead of Console.WriteLine

44d979f

Update BridgeConnector.cs

e7c5627

Update BridgeConnector.cs

1161f59

improve reconnect logic

81a8367

improve reconnect logic by waiting for reconnect before emit

7ad6803

Add supported OS platform annotations

224bc1e

missing using

0728577

remove defaultvaluehandling setting as this breaks some cases

efdaf0e

(like X:0 on browser view set bounds)

restore serialization settings where it makes sense

89d41a2

ignore process closing if going for an update

35b18a9

remove recreate behaviour from activate event on mac, and emit event …

bd45e23

…to handler instead

Add excludedFromShownWindowsMenu and TrafficLightPosition

5ba1013

Fix property assignment

7b5bac2

add handler for errors on socket.on calls

548609f

Fix LogError call

2d68ca5

use concurrent dictionary instead of list

9a938dc

fix creation of windows not being thread safe

794248a

Add event handler with sender id

eac1442

fix getting id

1e7ff5b

fix wrong Id being passed - needed browser id, not webcontent id

a2579b2

Update ipc.js

ec74c79

fix closed behaviour

4e7cebe

Revert "fix closed behaviour"

badc9f2

This reverts commit 4e7cebe.

Another attempt

14ee45b

Update to Electron 14

25af4a7

fix display serialization, serialize only window id when sending ipc …

5f4b162

…message

fix ipc data serialization

4fae2ae

remove debug message

c229d49

remove semaphore in favor of unique events per window /view create re…

bb8965f

…quest

theolivenbaum added 11 commits June 8, 2022 20:20

Release 19.0.3

79ce1c4

Release 19.0.4

ff05ef2

Change to use ImageSharp

e0000f7

Change to use ImageSharp

4906bab

merge ElectronNET#673

68c9e80

merge ElectronNET#624

5761404

Drop net5.0

1f22be6

Release 19.0.5

2f73bb8

Release 19.0.6

c8f944a

Update main.js

b7ed3d2

Fix wrong variable name

a19e095

theolivenbaum added 2 commits June 28, 2022 15:40

Update main.js

e1c5b7e

Release 19.0.8

7333018

theolivenbaum changed the title ~~Updates all the way to 18.0.2~~ Updates all the way to 19.0.8 Jul 12, 2022

theolivenbaum added 3 commits July 14, 2022 16:53

Import SocketIO code

e2615a8

Add experimental mode to start electron from C# (for development purp…

90b4a28

…oses)

Return socket port

89033c6

GregorBiswanger mentioned this pull request Jul 18, 2022

Version 18.6.1 #710

Closed

Release 19.0.9

a5bc910

GregorBiswanger merged commit d3aa978 into ElectronNET:master Jul 28, 2022

GregorBiswanger mentioned this pull request Aug 11, 2022

The framework version '5.0.0' (x64) was not found. But 6.0.6 is installed #704

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Updates all the way to 19.0.8#681

Updates all the way to 19.0.8#681
GregorBiswanger merged 196 commits intoElectronNET:masterfrom
theolivenbaum:master

theolivenbaum commented Apr 7, 2022

Uh oh!

GregorBiswanger commented Jun 27, 2022

Uh oh!

GregorBiswanger commented Jul 12, 2022

Uh oh!

theolivenbaum commented Jul 12, 2022 •

edited

Loading

Uh oh!

lafleurh commented Jul 26, 2022

Uh oh!

GregorBiswanger commented Jul 26, 2022

Uh oh!

GregorBiswanger commented Jul 28, 2022

Uh oh!

GregorBiswanger commented Jul 28, 2022

Uh oh!

GregorBiswanger commented Oct 3, 2022

Uh oh!

lafleurh commented Oct 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

theolivenbaum commented Apr 7, 2022

Uh oh!

GregorBiswanger commented Jun 27, 2022

Uh oh!

GregorBiswanger commented Jul 12, 2022

Uh oh!

theolivenbaum commented Jul 12, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lafleurh commented Jul 26, 2022

Uh oh!

GregorBiswanger commented Jul 26, 2022

Uh oh!

GregorBiswanger commented Jul 28, 2022

Uh oh!

GregorBiswanger commented Jul 28, 2022

Uh oh!

GregorBiswanger commented Oct 3, 2022

Uh oh!

lafleurh commented Oct 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

theolivenbaum commented Jul 12, 2022 •

edited

Loading