[UI] Fix for copy to clipboard #2631
Open
+34
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76d8bc3 to
fa5d5b5
Compare
Contributor
|
That's not working on https is a security feature by the browser. Not sure if we should override that. Just hide the copy fields on non https if you want to improve UX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
There are three places offering copy-to-clipboard functionality:
When working on non-https connection (usually installation / debug / some local instanced) - the copy to clipboard function was not working.
#2524 fixed the code for api page, but still debug was not fixed.
Solution:
This PR introduces shared function to common.js and updates are places to use the common function. This will eliminate redundant code and make the common approach.