Skip to content

[API Page] Fix and improvement for JavaScript #2524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AndreasK79 merged 2 commits into from
Nov 13, 2025
Merged

[API Page] Fix and improvement for JavaScript #2524

AndreasK79 merged 2 commits into from
Nov 13, 2025

Conversation

@szporwolik
Copy link
Contributor

@szporwolik szporwolik commented Nov 12, 2025

Problems:

  • copy to clipboard is not working on older browsers
  • copy to clipboard is not working without https connection
  • javascript for API page nested in the footer

Solutions:

  • Added fallback code using legacy solution for copy to clipboard
  • Seperated javascript following good practices in the code

@szporwolik szporwolik changed the title [APi Page] Fix and improvment for javascript. [API Page] Fix and improvement for JavaScript Nov 12, 2025
@szporwolik szporwolik marked this pull request as draft November 12, 2025 22:51
@szporwolik szporwolik marked this pull request as ready for review November 12, 2025 22:52
@AndreasK79 AndreasK79 merged commit b428f8f into wavelog:dev Nov 13, 2025
@szporwolik szporwolik deleted the dev_fix_copy_to_clipboard branch November 16, 2025 12:00
@szporwolik szporwolik mentioned this pull request Dec 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreasK79 AndreasK79 AndreasK79 approved these changes

@phl0 phl0 phl0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szporwolik @AndreasK79 @phl0