-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
chore!: drop support for node.js version 16. #15623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
62e2f9b to
88e64ff
Compare
| "@types/babel__generator": ^7.0.0 | ||
| "@types/babel__template": ^7.0.2 | ||
| "@types/node": ^16.10.0 | ||
| "@types/node": ^18.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unable to update @types/node to version 18.18. The typing in packages/jest-runtime/src/index.ts is completely broken.
Any assistance from @SimenB would be greatly appreciated. This pull request is not blocked, but it does prevent any future updates to Node.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! I just stumbled across the fact we lock down to an old version of TS and followed the breadcrumbs here 😀 Sorry I missed your ping.
I gave updating a whack in #15861, let's see how it goes!
ef1ea72 to
185a78f
Compare
package.json
Outdated
| "ts-node": "^10.5.0", | ||
| "tstyche": "^4.0.0-rc.0", | ||
| "typescript": "^5.0.4", | ||
| "typescript": "~5.5.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typescript was downgraded from 5.8 to 5.4 because of issue: microsoft/TypeScript#59982
This issue fixes by upgrading @types/node to 18.18, but, as I mention above, it breaks typings in jest-runtime package.
81a8662 to
74860db
Compare
cpojer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, quite the cleanup. Thank you!
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Unblock: #15473