Skip to content

Conversation

@MillerSvt
Copy link
Contributor

@MillerSvt MillerSvt commented May 25, 2025

Unblock: #15473

@netlify
Copy link

netlify bot commented May 25, 2025

Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 87f13f2
🔍 Latest deploy log https://app.netlify.com/projects/jestjs/deploys/68344cd9674c4c0008a34368
😎 Deploy Preview https://deploy-preview-15623--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MillerSvt MillerSvt force-pushed the drop-node-16 branch 2 times, most recently from 62e2f9b to 88e64ff Compare May 25, 2025 16:22
"@types/babel__generator": ^7.0.0
"@types/babel__template": ^7.0.2
"@types/node": ^16.10.0
"@types/node": ^18.14
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unable to update @types/node to version 18.18. The typing in packages/jest-runtime/src/index.ts is completely broken.

Any assistance from @SimenB would be greatly appreciated. This pull request is not blocked, but it does prevent any future updates to Node.js.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! I just stumbled across the fact we lock down to an old version of TS and followed the breadcrumbs here 😀 Sorry I missed your ping.

I gave updating a whack in #15861, let's see how it goes!

@MillerSvt MillerSvt force-pushed the drop-node-16 branch 3 times, most recently from ef1ea72 to 185a78f Compare May 26, 2025 07:41
package.json Outdated
"ts-node": "^10.5.0",
"tstyche": "^4.0.0-rc.0",
"typescript": "^5.0.4",
"typescript": "~5.5.4",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript was downgraded from 5.8 to 5.4 because of issue: microsoft/TypeScript#59982

This issue fixes by upgrading @types/node to 18.18, but, as I mention above, it breaks typings in jest-runtime package.

@MillerSvt MillerSvt force-pushed the drop-node-16 branch 2 times, most recently from 81a8662 to 74860db Compare May 26, 2025 09:05
Copy link
Member

@cpojer cpojer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, quite the cleanup. Thank you!

@cpojer cpojer merged commit 57a0ef1 into jestjs:main May 26, 2025
85 checks passed
@MillerSvt MillerSvt deleted the drop-node-16 branch May 27, 2025 03:57
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants