Skip to content

chore: drop TypeScript versions below 5.4 #15621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 3 commits into from
May 24, 2025
Merged

chore: drop TypeScript versions below 5.4 #15621

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f09dff
chore: drop TypeScript versions below 5.4
SimenB May 24, 2025
e4892bc
changelog
SimenB May 24, 2025
000ab4c
add empty tsconfig in test so it skips the one in root
SimenB May 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: drop TypeScript versions below 5.4
  • Loading branch information
@SimenB
SimenB committed May 24, 2025
commit 3f09dfffd8fd4114aeb6ab64152835c1da279996
4 changes: 2 additions & 2 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ jobs:
- name: ts integration
run: yarn test-ts --selectProjects ts-integration
- name: type tests
run: yarn test-types --target 5.0,current
- name: verify TypeScript@5.0 compatibility
run: yarn test-types --target 5.4,current
- name: verify TypeScript@5.4 compatibility
run: yarn verify-old-ts
- name: run ESLint with type info
run: yarn lint-ts-files
Expand Down
2 changes: 1 addition & 1 deletion scripts/verifyOldTs.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const tsConfig = {
};
/* eslint-enable sort-keys */

const tsVersion = '5.0';
const tsVersion = '5.4';

function smoketest() {
const jestDirectory = path.resolve(
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"$schema": "https://json.schemastore.org/tsconfig",
"extends": "@tsconfig/node16/tsconfig.json",
"compilerOptions": {
"module": "commonjs",
"moduleResolution": "node",
"module": "preserve",
"moduleResolution": "bundler",
"composite": true,
"declaration": true,
"emitDeclarationOnly": true,
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.typetest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"extends": "@tsconfig/node16/tsconfig.json",
"compilerOptions": {
"module": "commonjs",
"moduleResolution": "node",
"module": "preserve",
"moduleResolution": "bundler",
"noEmit": true,
"noUnusedLocals": false,
"noUnusedParameters": false,
Expand Down
Loading