Skip to content

Fix error message for sl (steam locomotive) #15052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 2 commits into from
May 8, 2024
Merged

Fix error message for sl (steam locomotive) #15052

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7edc18d
Fix error message for `sl` (steam locomotive)
rmartine-ias May 3, 2024
0067f96
Make other VCS errors print as well
rmartine-ias May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix error message for sl (steam locomotive) 
When running jest in watch mode, with `sl` installed
(https://github.com/mtoyoda/sl), it errors out with the following
message:

```
  ● Test suite failed to run

thrown: [Error]
```

This is bad because the error is extremely hard to debug.

This change makes it error as follows:

```
  ● Test suite failed to run

    Command failed with ENAMETOOLONG: sl status -amnu /Users/rmartine/dev/ias-backstage/packages/backend
    spawn ENAMETOOLONG
```

This, at least, points people in the right direction.

See also: #14046
  • Loading branch information
@rmartine-ias
rmartine-ias committed May 3, 2024
commit 7edc18d986fd8c9cfda473e9937e4c1a0fc39a11
15 changes: 1 addition & 14 deletions packages/jest-changed-files/src/sl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/

import * as path from 'path';
import {types} from 'util';
import execa = require('execa');
import type {SCMAdapter} from './types';

Expand All @@ -34,19 +33,7 @@ const adapter: SCMAdapter = {
}
args.push(...includePaths);

let result: execa.ExecaReturnValue;

try {
result = await execa('sl', args, {cwd, env});
} catch (error) {
if (types.isNativeError(error)) {
const err = error as execa.ExecaError;
// TODO: Should we keep the original `message`?
err.message = err.stderr;
}

throw error;
}
const result = await execa('sl', args, {cwd, env});
Copy link
Member

@SimenB SimenB May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the same change for all the VCS checks? trying to silence the error doesn't really seem useful in this case

Copy link
Contributor Author

@rmartine-ias rmartine-ias May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made the change, added changelog entry!


return result.stdout
.split('\n')
Expand Down