Skip to content

fix: make sure atob and btoa are writeable #14446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 6 commits into from
Aug 24, 2023
Merged

fix: make sure atob and btoa are writeable #14446

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cda892
fix: make sure `atob` and `btoa` are writeable
SimenB Aug 24, 2023
69eda2a
conditional
SimenB Aug 24, 2023
4f9b357
always writeable
SimenB Aug 24, 2023
0e5dbed
simpler
SimenB Aug 24, 2023
f6f7129
lint
SimenB Aug 24, 2023
db2a544
Update CHANGELOG.md
SimenB Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
always writeable
  • Loading branch information
@SimenB
SimenB committed Aug 24, 2023
commit 4f9b3575694063d2925296e8078c757b7d92f3e9
7 changes: 7 additions & 0 deletions e2e/override-globals/__tests__/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,11 @@ describe('parent', () => {
}, 10);
});
});

it('can override atob and btoa', () => {
global.atob = () => 'hello';
global.btoa = () => 'there';

expect(`${atob()} ${btoa()}`).toBe('hello there');
});
});
37 changes: 10 additions & 27 deletions packages/jest-environment-node/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,41 +90,24 @@ export default class NodeEnvironment implements JestEnvironment<Timer> {
configurable: true,
enumerable: descriptor.enumerable,
get() {
const attributes: PropertyDescriptor = {
configurable: true,
};

if ('value' in descriptor) {
attributes.value = descriptor.value;
}

if ('writable' in descriptor) {
attributes.writable = descriptor.writable;
}

if ('enumerable' in descriptor) {
attributes.enumerable = descriptor.enumerable;
}

if ('get' in descriptor) {
attributes.get = descriptor.get;
}

if ('set' in descriptor) {
attributes.set = descriptor.set;
}
const value = globalThis[nodeGlobalsKey];

// override lazy getter
Object.defineProperty(global, nodeGlobalsKey, attributes);
Object.defineProperty(global, nodeGlobalsKey, {
configurable: true,
enumerable: descriptor.enumerable,
value,
writable: true,
Copy link
Member Author

@SimenB SimenB Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the only code change - if people wanna override globals, then sure 🤷

});

return globalThis[nodeGlobalsKey];
return value;
},
set(val: unknown) {
set(value: unknown) {
// override lazy getter
Object.defineProperty(global, nodeGlobalsKey, {
configurable: true,
enumerable: descriptor.enumerable,
value: val,
value,
writable: true,
});
},
Expand Down