Skip to content

fix: isolate esm async import bug #14397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 15 commits into from
Aug 21, 2023
Merged

fix: isolate esm async import bug #14397

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3df4711
fix: isolate esm async import bug
eryue0220 Aug 9, 2023
e6ba77b
fix: add test plan
eryue0220 Aug 9, 2023
a53ffa5
chore: update pkg.json && readme
eryue0220 Aug 9, 2023
54ff86e
fix: code review
eryue0220 Aug 10, 2023
08f9bb8
fix: e2e test update
eryue0220 Aug 10, 2023
3710da6
chore: remote config
eryue0220 Aug 10, 2023
60f9f59
fix: cr problem
eryue0220 Aug 10, 2023
3a9d0a6
chore: refactor file
eryue0220 Aug 12, 2023
e12f6ab
fix: e2e test
eryue0220 Aug 12, 2023
3bbf1ba
fix: remove property
eryue0220 Aug 12, 2023
ce55918
fix: resolve conflict
eryue0220 Aug 12, 2023
e959b07
fix: resolve conflict
eryue0220 Aug 18, 2023
d218ca0
Merge branch 'main' into fix/issue-14387
SimenB Aug 21, 2023
6f7d689
move changelog entry
SimenB Aug 21, 2023
a06645e
Merge branch 'main' into fix/issue-14387
SimenB Aug 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: code review
  • Loading branch information
@eryue0220
eryue0220 committed Aug 10, 2023
commit 54ff86e0cda477f0ced0080120cf4a82dfc0d6c0
4 changes: 2 additions & 2 deletions e2e/async-esm-import/__tests__/test.js → e2e/async-esm-import/__tests__/main.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ import {jest} from '@jest/globals';

test('should have a fresh module state in each isolateModulesAsync context', async () => {
await jest.isolateModulesAsync(async () => {
const {getState, incState} = await import('../main.js');
const {getState, incState} = await import('../main.mjs');
expect(getState()).toBe(0);
incState();
expect(getState()).toBe(1);
});
await jest.isolateModulesAsync(async () => {
const {getState, incState} = await import('../main.js');
const {getState, incState} = await import('../main.mjs');
expect(getState()).toBe(0);
incState();
expect(getState()).toBe(1);
Expand Down
0 e2e/async-esm-import/main.js → e2e/async-esm-import/main.mjs
View file
Open in desktop
File renamed without changes.
9 changes: 8 additions & 1 deletion e2e/async-esm-import/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
{
"name": "async-esm-import",
"jest": {
"testEnvironment": "node"
"testEnvironment": "node",
"testRegex": "(/__tests__/.*|(\\.|/)(test|spec))\\.(js?|ts?|mjs?|mts?)$",
"moduleFileExtensions": [
"js",
"ts",
"mjs",
"mts"
]
}
}
1 change: 1 addition & 0 deletions e2e/resolve-async/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"type": "module",
"jest": {
"resolver": "<rootDir>/resolver.cjs",
"transform": {}
Expand Down