Skip to content

fix(jest-matcher-utils): compare value of inherited getter on test failure (#10167) #14007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 3 commits into from
Mar 20, 2023
Merged

fix(jest-matcher-utils): compare value of inherited getter on test failure (#10167) #14007

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7eeacae
fix: compare value of inherited getter on test failure (#10167)
BenceSzalai Mar 14, 2023
405a8fe
chore: update CHANGELOG.md
BenceSzalai Mar 14, 2023
b860071
style: fix formatting issues
BenceSzalai Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
style: fix formatting issues
  • Loading branch information
@BenceSzalai
BenceSzalai committed Mar 20, 2023
commit b860071544adcee2434c656e00453a819c6902b7
11 changes: 9 additions & 2 deletions packages/jest-matcher-utils/src/deepCyclicCopyReplaceable.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,15 @@ function deepCyclicCopyObject<T>(object: T, cycles: WeakMap<any, unknown>): T {
let descriptors: Record<string, PropertyDescriptor> = {};
let obj = object;
do {
descriptors = Object.assign({}, Object.getOwnPropertyDescriptors(obj), descriptors)
} while ( (obj = Object.getPrototypeOf( obj )) && obj !== Object.getPrototypeOf({}) );
descriptors = Object.assign(
{},
Object.getOwnPropertyDescriptors(obj),
descriptors,
);
} while (
(obj = Object.getPrototypeOf(obj)) &&
obj !== Object.getPrototypeOf({})
);

cycles.set(object, newObject);

Expand Down