Skip to content

feat(jest-config): openHandlesTimeout config option #13875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 13 commits into from
Feb 23, 2023
Merged

feat(jest-config): openHandlesTimeout config option #13875

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
04ff365
Add `openHandlesTimeout` config option
robhogan Feb 8, 2023
20cc208
Add snapshot test
robhogan Feb 8, 2023
df3c63a
Changelog entry
robhogan Feb 8, 2023
f701621
PR number in changelog
robhogan Feb 8, 2023
ce8f5f7
Lint
robhogan Feb 8, 2023
411d3c7
Prettier
robhogan Feb 8, 2023
2159407
Document in Configuration.md
robhogan Feb 8, 2023
6ed2358
Add `openHandlesTimeout` to CLI args
robhogan Feb 8, 2023
23f1951
Move `openHandlesTimeout` to proper place in Configuration.md
robhogan Feb 8, 2023
ddeb564
args.ts ordering
robhogan Feb 8, 2023
990ee67
Update test snapshots
robhogan Feb 8, 2023
adb9846
Merge branch 'facebook:main' into feat/openhandlestimeout
robhogan Feb 14, 2023
df4654f
Merge branch 'main' into feat/openhandlestimeout
SimenB Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Lint
  • Loading branch information
@robhogan
robhogan committed Feb 8, 2023
commit ce8f5f77e458069cb62f12adb45cd7f4be8dd3a1
5 changes: 4 additions & 1 deletion e2e/__tests__/detectOpenHandles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,10 @@ it('prints message about flag on slow tests', async () => {
});

it('prints message about flag on slow tests with a custom timeout', async () => {
const run = runContinuous('detect-open-handles', ['outside', '--openHandlesTimeout=500']);
const run = runContinuous('detect-open-handles', [
'outside',
'--openHandlesTimeout=500',
]);
await run.waitUntil(({stderr}) =>
stderr.includes('Jest did not exit 0.5 seconds'),
);
Expand Down
2 changes: 1 addition & 1 deletion packages/jest-config/src/ValidConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,9 +114,9 @@ export const initialOptions: Config.InitialOptions = {
noStackTrace: false,
notify: false,
notifyMode: 'failure-change',
openHandlesTimeout: 1000,
onlyChanged: false,
onlyFailures: false,
openHandlesTimeout: 1000,
passWithNoTests: false,
preset: 'react-native',
prettierPath: '<rootDir>/node_modules/prettier',
Expand Down