Skip to content

feat(@jest/expect): Expose type of actual to Matchers #13848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SimenB merged 8 commits into from
Feb 2, 2023
Merged

feat(@jest/expect): Expose type of actual to Matchers #13848

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4bfbc6b
feat(@jest/expect): Expose type of actual to Matchers
benjaminjkraft Jan 31, 2023
b9c5c27
review comments
benjaminjkraft Feb 1, 2023
d6459b4
add PR number in changelog
benjaminjkraft Feb 1, 2023
2b7490e
changelog comments
benjaminjkraft Feb 1, 2023
2b4fa2d
Update CHANGELOG.md
benjaminjkraft Feb 1, 2023
fc53bed
better way to avoid unused variable errors
benjaminjkraft Feb 1, 2023
6230a94
review comments
benjaminjkraft Feb 1, 2023
12d3bcc
review comments, again
benjaminjkraft Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better way to avoid unused variable errors
  • Loading branch information
@benjaminjkraft
benjaminjkraft committed Feb 1, 2023
commit fc53bed9d70d8de2d7d19d803794609203cb2df9
11 changes: 9 additions & 2 deletions packages/expect/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,16 @@ type PromiseMatchers<T = unknown> = {
resolves: Matchers<Promise<void>, T> & Inverse<Matchers<Promise<void>, T>>;
};

// @ts-expect-error unused variable T (can't use _T since users redeclare Matchers)
// eslint-disable-next-line @typescript-eslint/no-unused-vars
export interface Matchers<R extends void | Promise<void>, T = unknown> {
/**
* T is a type param for the benefit of users who extend Matchers. It's
* intentionally unused and needs to be named T, not _T, for those users.
* This makes sure Typescript agrees.
*
* @internal
*/
_unusedT(expected: T): R;

/**
* Ensures the last call to a mock function was provided specific args.
*/
Expand Down