Skip to content

refactor(flutter_bloc): remove unnecessary single child widget mixins #3675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felangel merged 2 commits into from
Jan 30, 2023
Merged

refactor(flutter_bloc): remove unnecessary single child widget mixins #3675

felangel merged 2 commits into from
Jan 30, 2023

Conversation

@felangel
Copy link
Owner

@felangel felangel commented Dec 27, 2022

Status

HOLD

Breaking Changes

NO

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added pkg:flutter_bloc This issue is related to the flutter_bloc package refactor Refactor an existing implementation labels Dec 27, 2022
@felangel felangel self-assigned this Dec 27, 2022
@codecov
Copy link

codecov bot commented Dec 27, 2022 •
edited
Loading

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (cd1ef9f) compared to base (2199f1c).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master     #3675   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        15    -1     
  Lines          455       410   -45     
=========================================
- Hits           455       410   -45
Impacted Files Coverage Δ
packages/flutter_bloc/lib/src/bloc_listener.dart 100.00% <ø> (ø)
packages/flutter_bloc/lib/src/bloc_provider.dart 100.00% <ø> (ø)
...ages/flutter_bloc/lib/src/multi_bloc_listener.dart 100.00% <ø> (ø)
...ages/flutter_bloc/lib/src/multi_bloc_provider.dart 100.00% <ø> (ø)
...lutter_bloc/lib/src/multi_repository_provider.dart 100.00% <ø> (ø)
...ages/flutter_bloc/lib/src/repository_provider.dart 100.00% <ø> (ø)
packages/bloc_tools/lib/src/command_runner.dart

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felangel felangel merged commit f8a3c74 into master Jan 30, 2023
@felangel felangel deleted the refactor/flutter-bloc-remove-single-child-mixins branch January 30, 2023 02:53
@felangel felangel mentioned this pull request Feb 7, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@felangel felangel

Labels

pkg:flutter_bloc This issue is related to the flutter_bloc package refactor Refactor an existing implementation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

refactor: expose BlocListenerSingleChildWidget

1 participant

@felangel