Skip to content

fix(flutter_bloc): BlocListener, BlocProvider missing child assertion #2924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felangel merged 2 commits into from
Nov 7, 2021
Merged

fix(flutter_bloc): BlocListener, BlocProvider missing child assertion #2924

felangel merged 2 commits into from
Nov 7, 2021
+50 −1

Conversation

@felangel
Copy link
Owner

@felangel felangel commented Nov 5, 2021

Status

READY

Breaking Changes

NO

Description

  • fix(flutter_bloc): BlocListener, BlocProvider missing child assertion

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package labels Nov 5, 2021
@felangel felangel self-assigned this Nov 5, 2021
@codecov
Copy link

codecov bot commented Nov 5, 2021 •
edited
Loading

Codecov Report

Merging #2924 (c4f39a6) into master (22e13c5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #2924    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           25         9    -16     
  Lines          720       176   -544     
==========================================
- Hits           720       176   -544
Impacted Files Coverage Δ
packages/flutter_bloc/lib/src/bloc_listener.dart 100.00% <100.00%> (ø)
packages/flutter_bloc/lib/src/bloc_provider.dart 100.00% <100.00%> (ø)
packages/replay_bloc/lib/src/change_stack.dart
packages/bloc_test/lib/src/when_listen.dart
packages/bloc_concurrency/lib/src/droppable.dart
packages/bloc_test/lib/src/bloc_test.dart
...ackages/hydrated_bloc/lib/src/hydrated_cipher.dart
packages/replay_bloc/lib/src/replay_bloc.dart
packages/bloc/lib/src/transition.dart
...ckages/hydrated_bloc/lib/src/hydrated_storage.dart
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22e13c5...c4f39a6. Read the comment docs.

@felangel felangel mentioned this pull request Nov 5, 2021
Closed
7 tasks
jeroen-meijer
jeroen-meijer approved these changes Nov 6, 2021
View reviewed changes
Copy link
Collaborator

@jeroen-meijer jeroen-meijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor styling comments. Other than that; 👌🏻 :shipit:

packages/flutter_bloc/test/bloc_listener_test.dart
tester.takeException(),
isA<AssertionError>().having((e) => e.message, 'message', expected),
);
});
Copy link
Collaborator

@jeroen-meijer jeroen-meijer Nov 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
});
},
);

and format

Same goes for other tests, though I'm not sure what you're styling convention is here so feel free to ignore! 😄

Copy link
Owner Author

@felangel felangel Nov 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For internal consistency I prefer to leave the test format as is but thanks for the review, really appreciate it!

marcossevilla
marcossevilla approved these changes Nov 6, 2021
View reviewed changes
Copy link
Collaborator

@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@felangel felangel merged commit cd62ecc into master Nov 7, 2021
@felangel felangel deleted the fix/bloc-listener/provider-missing-child-assertion branch November 7, 2021 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeroen-meijer jeroen-meijer jeroen-meijer approved these changes

@marcossevilla marcossevilla marcossevilla approved these changes

@jolexxa jolexxa Awaiting requested review from jolexxa

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@felangel felangel

Labels

bug Something isn't working pkg:flutter_bloc This issue is related to the flutter_bloc package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felangel @jeroen-meijer @marcossevilla