-
-
Notifications
You must be signed in to change notification settings - Fork 48
feat: Add types to package #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
650a0fa
chore: Upgrade ESLint
nzakas a207afc
Add back eslintignore
nzakas cb72100
Skip tests relying on project files
nzakas f46851e
feat: Add type definitions
nzakas 049d0a0
Replace deprecated type
nzakas 959bb54
Add missing JSDoc comments
nzakas c405b62
Fix linting error
nzakas c430baf
Remove ExpectType and update types test
nzakas 0c9da57
Remove lib from tsconfig.json
nzakas 0fb54fc
Update package.json
nzakas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /** | ||
| * @fileoverview This file contains the core types for ESLint. It was initially extracted | ||
| * from the `@types/eslint__eslintrc` package. | ||
| */ | ||
|
|
||
| /* | ||
| * MIT License | ||
| * Copyright (c) Microsoft Corporation. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE | ||
| */ | ||
|
|
||
| import type { Linter } from "eslint"; | ||
|
|
||
| /** | ||
| * A compatibility class for working with configs. | ||
| */ | ||
| export class FlatCompat { | ||
| constructor({ | ||
| baseDirectory, | ||
| resolvePluginsRelativeTo, | ||
| recommendedConfig, | ||
| allConfig, | ||
| }?: { | ||
| /** | ||
| * default: process.cwd() | ||
| */ | ||
| baseDirectory?: string; | ||
| resolvePluginsRelativeTo?: string; | ||
| recommendedConfig?: Linter.LegacyConfig; | ||
| allConfig?: Linter.LegacyConfig; | ||
| }); | ||
|
|
||
| /** | ||
| * Translates an ESLintRC-style config into a flag-config-style config. | ||
| * @param eslintrcConfig The ESLintRC-style config object. | ||
| * @returns A flag-config-style config object. | ||
| */ | ||
| config(eslintrcConfig: Linter.LegacyConfig): Linter.Config[]; | ||
|
|
||
| /** | ||
| * Translates the `env` section of an ESLintRC-style config. | ||
| * @param envConfig The `env` section of an ESLintRC config. | ||
| * @returns An array of flag-config objects representing the environments. | ||
| */ | ||
| env(envConfig: { [name: string]: boolean }): Linter.Config[]; | ||
|
|
||
| /** | ||
| * Translates the `extends` section of an ESLintRC-style config. | ||
| * @param configsToExtend The names of the configs to load. | ||
| * @returns An array of flag-config objects representing the config. | ||
| */ | ||
| extends(...configsToExtend: string[]): Linter.Config[]; | ||
|
|
||
| /** | ||
| * Translates the `plugins` section of an ESLintRC-style config. | ||
| * @param plugins The names of the plugins to load. | ||
| * @returns An array of flag-config objects representing the plugins. | ||
| */ | ||
| plugins(...plugins: string[]): Linter.Config[]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "compilerOptions": { | ||
| "module": "node16", | ||
| "lib": [ | ||
| "dom", | ||
nzakas marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "es6" | ||
| ], | ||
| "noImplicitAny": true, | ||
| "noImplicitThis": true, | ||
| "strictNullChecks": true, | ||
| "strictFunctionTypes": true, | ||
| "types": [], | ||
| "noEmit": true, | ||
| "forceConsistentCasingInFileNames": true, | ||
| "exactOptionalPropertyTypes": true | ||
| }, | ||
| "files": [ | ||
| "../../../lib/types/index.d.ts", | ||
| "types.test.mts" | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| /** | ||
| * @fileoverview This file contains tests for types. It was initially extracted | ||
| * from the `@types/eslint__eslintrc` package. | ||
| */ | ||
|
|
||
| /* | ||
| * MIT License | ||
| * Copyright (c) Microsoft Corporation. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE | ||
| */ | ||
|
|
||
|
|
||
| import { FlatCompat } from "../../../lib/types/index.js"; | ||
| import { Linter } from "eslint"; | ||
|
|
||
| const __dirname = "/path/to/project"; | ||
|
|
||
| const compat = new FlatCompat({ | ||
| baseDirectory: __dirname, | ||
| resolvePluginsRelativeTo: __dirname, | ||
| }); | ||
|
|
||
| const config: Linter.FlatConfig[] = [ | ||
| // $ExpectType FlatConfig | ||
nzakas marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| ...compat.extends("standard", "example"), | ||
|
|
||
| // $ExpectType FlatConfig | ||
| ...compat.env({ | ||
| es2020: true, | ||
| node: true, | ||
| }), | ||
|
|
||
| // $ExpectType FlatConfig | ||
| ...compat.plugins("airbnb", "react"), | ||
|
|
||
| // $ExpectType FlatConfig | ||
| ...compat.config({ | ||
| plugins: ["airbnb", "react"], | ||
| extends: "standard", | ||
| env: { | ||
| es2020: true, | ||
| node: true, | ||
| }, | ||
| rules: { | ||
| semi: "error", | ||
| }, | ||
| }), | ||
| ]; | ||
|
|
||
| export default config; | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.