Skip to content

fix: avoid false positive in no-unassigned-vars for declare module #19746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdjermanovic merged 4 commits into from
May 25, 2025
+43 −6
Merged

fix: avoid false positive in no-unassigned-vars for declare module #19746

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
27b350b
fix: avoid false positive in `no-unassigned-vars` for declare module
azat-io May 19, 2025
382a37a
docs: add declare module example in `no-unassigned-vars` rule
azat-io May 22, 2025
b73c0fa
perf: use flag instead of `getAncestors` in `no-unassigned-vars rule`
azat-io May 25, 2025
744e3f2
test: add flag reset test for `no-unassigned-vars`
azat-io May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/src/rules/no-unassigned-vars.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ In TypeScript:

declare let value: number | undefined;
console.log(value);

declare module "my-module" {
let value: string;
export = value;
}
```

:::
Expand Down
19 changes: 13 additions & 6 deletions lib/rules/no-unassigned-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,19 @@ module.exports = {
VariableDeclarator(node) {
/** @type {import('estree').VariableDeclaration} */
const declaration = node.parent;
const shouldCheck =
!node.init &&
node.id.type === "Identifier" &&
declaration.kind !== "const" &&
!declaration.declare;
if (!shouldCheck) {
const ancestors = context.sourceCode.getAncestors(node);
const insideDeclareModule = ancestors.some(
ancestorNode =>
ancestorNode.type === "TSModuleDeclaration" &&
ancestorNode.declare === true,
);
const shouldSkip =
node.init ||
node.id.type !== "Identifier" ||
declaration.kind === "const" ||
declaration.declare ||
insideDeclareModule;
if (shouldSkip) {
return;
}
const [variable] = sourceCode.getDeclaredVariables(node);
Expand Down
7 changes: 7 additions & 0 deletions tests/lib/rules/no-unassigned-vars.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,13 @@ ruleTesterTypeScript.run("no-unassigned-vars", rule, {
}
}
`,
unIndent`
declare module 'module' {
import type { T } from 'module';
let x: T;
export = x;
}
`,
],
invalid: [
{
Expand Down
Loading