Fix regression in ESM plugin loading #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n it is the only available export
bmish
approved these changes
Mar 16, 2025
Owner
bmish
left a comment
There was a problem hiding this comment.
Thanks.
Ideally we can add some tests for this in the near future, although I know it's kind of annoying to test.
Owner
|
@marcalexiei yes I'd love if there was a way to simplify this logic or make it more robust. Loading the plugin is quite painful right now. Feel free to experiment with improvements. |
This was referenced Jun 22, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #656
To prevent the reintroduction of #615,
I refined the condition in
package.jsonto return thedefaultexport only if it is the only available export.Otherwise, the module will be returned as-is, which should resolve #656.
Note
Since this package supports relatively recent versions of Node:
eslint-doc-generator/package.json
Lines 95 to 97 in cc4d7d6
the entire function could potentially be refactored in the future to primarily use an dynamic
importinstead ofrequire.For reference: Node's import support status.
Let me know if it's something you're interested in exploring!