feat(oss-opensearch): Add version compatibility for 2.x and 3.x #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Akhil-Pathivada The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
/assign @alwayslove2013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds version compatibility to the OpenSearch client, allowing it to work correctly with both OpenSearch 2.x and 3.x clusters. It resolves a critical issue where 3.x-specific index settings were being sent to 2.x clusters, causing index creation to fail.
Changes
.info()API and thepackaginglibrary for accurate semantic version comparisons.VERSION_SPECIFIC_SETTING_RULES) to apply only compatible settings based on the detected cluster version.Files Modified
vectordb_bench/backend/clients/oss_opensearch/oss_opensearch.pyinstall/requirements_py3.11.txtKey Features
✅ Backward Compatible: Now works with OpenSearch 2.x clusters.
✅ Future-Proof: The new design makes it trivial to add rules for future OpenSearch versions.
✅ Robust Error Handling: Prevents ambiguous states by failing fast if the cluster version is unknown.