security: add update size limits to prevent DOS attacks #688
+153
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gvergnaud
commented
Jan 9, 2025
Comment on lines
+1
to
+4
| export const MAX_STRUCTS = 100_000 | ||
| export const MAX_UPDATES = 100_000 | ||
| export const MAX_GC_LENGTH = 100_000 | ||
| export const MAX_SKIP_LENGTH = 100_000 |
Author
There was a problem hiding this comment.
These limits are totally arbitrary, I don't know what numbers would make sense here.
Another approach I thought about was to increment a loop counter, and use the same limit for structs and updates. It might be preferable because 100_000**2 = 10B loops is also too many. I don't think this would work for GC and skip item lengths, though.
Happy to iterate on the solution!
2 tasks
50f9c28 to
d962252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #687