Skip to content

Conversation

@hiqsol
Copy link
Member

@hiqsol hiqsol commented Nov 23, 2016

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Fixed issues #38

Checked the generated docs for yiisoft/yii2.
Found no other special constants there.

@samdark samdark added this to the 2.0.7 milestone Nov 23, 2016
@samdark samdark added the type:bug Bug label Nov 23, 2016
return 'null';
}

static $specials = [
Copy link
Member

@cebe cebe Nov 23, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also cover 0666, 0664, 0644, 0777 and 0755.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

}

static $specials = [
'509' => '0775',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, maybe a comment should point to where it is used :)

@cebe
Copy link
Member

cebe commented Nov 23, 2016

Merged, thank you!

cebe pushed a commit that referenced this pull request Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants