Fix #234: Remove attribute sorting #236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #236 +/- ##
===========================================
Coverage 100.00% 100.00%
+ Complexity 812 809 -3
===========================================
Files 86 86
Lines 2221 2215 -6
===========================================
- Hits 2221 2215 -6 ☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Jan 15, 2025
Co-authored-by: Alexander Makarov <sam@rmcreative.ru>
vjik
approved these changes
Jan 16, 2025
Member
vjik
left a comment
There was a problem hiding this comment.
Looks good!
We'll merge it after other BC-break changes are added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.