Skip to content

BUG: fix qwen3-vl embedding model for vllm engine#4783

Merged
qinxuye merged 5 commits intoxorbitsai:mainfrom
llyycchhee:fix/qwen3-vl-embedding-error
Apr 11, 2026
Merged

BUG: fix qwen3-vl embedding model for vllm engine#4783
qinxuye merged 5 commits intoxorbitsai:mainfrom
llyycchhee:fix/qwen3-vl-embedding-error

Conversation

@llyycchhee
Copy link
Copy Markdown
Collaborator

@llyycchhee llyycchhee commented Apr 9, 2026

Fix qwen3-vl-embedding error.
Fix #4594
Fix #4722

@XprobeBot XprobeBot added this to the v2.x milestone Apr 9, 2026
@qinxuye qinxuye changed the title Fix/qwen3 vl embedding error BUG: fix qwen3-vl embedding model for vllm engine Apr 9, 2026
@XprobeBot XprobeBot added the bug Something isn't working label Apr 9, 2026
@qinxuye
Copy link
Copy Markdown
Contributor

qinxuye commented Apr 9, 2026

Lint failed, please fix it.

Add assert to ensure self._model is not None before accessing
llm_engine.tokenizer in _prepare_vllm_inputs method.
Copy link
Copy Markdown
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit dea9f7b into xorbitsai:main Apr 11, 2026
4 of 14 checks passed
qinxuye pushed a commit to qinxuye/inference that referenced this pull request Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

3 participants