Skip to content

BUG: Fix create_image_edits method for multiple files handling#4610

Merged
qinxuye merged 11 commits intoxorbitsai:mainfrom
lazariv:main
Feb 20, 2026
Merged

BUG: Fix create_image_edits method for multiple files handling#4610
qinxuye merged 11 commits intoxorbitsai:mainfrom
lazariv:main

Conversation

@lazariv
Copy link
Copy Markdown
Contributor

@lazariv lazariv commented Feb 18, 2026

Fixes #4609

@XprobeBot XprobeBot added this to the v2.x milestone Feb 18, 2026
@qinxuye qinxuye changed the title Fix create_image_edits method for multiple files handling BUG: Fix create_image_edits method for multiple files handling Feb 19, 2026
@XprobeBot XprobeBot added the bug Something isn't working label Feb 19, 2026
@qinxuye
Copy link
Copy Markdown
Contributor

qinxuye commented Feb 19, 2026

I checked the openai API:

https://developers.openai.com/api/reference/resources/images/methods/edit

It seems that images is the argument for editing.

I think we'd better try to keep compatibility as openai's.

Comment thread xinference/api/restful_api.py Outdated
@qinxuye
Copy link
Copy Markdown
Contributor

qinxuye commented Feb 20, 2026

Lint failed. Could you please fix it?

@lazariv
Copy link
Copy Markdown
Contributor Author

lazariv commented Feb 20, 2026

Lint failed. Could you please fix it?

All green now

Copy link
Copy Markdown
Contributor

@qinxuye qinxuye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinxuye qinxuye merged commit 532e0b2 into xorbitsai:main Feb 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Images edits endpoint is not handling multiple files correctly

3 participants