BUG: Fix typo in xinference/deploy/docker/Dockerfile.cu128#4350
Merged
qinxuye merged 1 commit intoxorbitsai:mainfrom Dec 10, 2025
Merged
BUG: Fix typo in xinference/deploy/docker/Dockerfile.cu128#4350qinxuye merged 1 commit intoxorbitsai:mainfrom
qinxuye merged 1 commit intoxorbitsai:mainfrom
Conversation
Signed-off-by: Hu Butui <hot123tea123@gmail.com>
Contributor
|
You seemed remove some path for LD_LIBRARY_PATH, why did you remove them? |
Contributor
Author
|
I just follow Do we need to add /usr/local/lib/python3.12/dist-packages/torch/lib to LD_LIBRARY_PATH?
|
Contributor
|
I need to confirm why this added for cu128, should be for some purpose. @zwt-1234 please take a look at it. |
Contributor
|
Did you encounter any problem? I just want to know other than refer to dockerfile, what issue did you find? |
Contributor
Author
|
nothing. without this change, in the container: echo $LD_LIBRARY_PATH
/usr/local/cuda/lib64:/usr/local/lib/python3.10/dist-packages/nvidia/cublas/lib:LD_LIBRARY_PATH=/usr/local/lib/python3.12/dist-packages/torch/lib:/usr/local/cuda/lib64
|
Contributor
|
Oh, you are right, the $LD_LIBRARY_PATH is wrong and actually takes no effect. |
Collaborator
是有因为这个配置遇到什么报错问题嘛 |
Contributor
|
I think you are right, approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix
LD_LIBRARY_PATHtypo.