Skip to content

SP ECC: ecc_point - add padding when 16 byte aligned #9634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SparkiDev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SP ECC: ecc_point - add padding when 16 byte aligned #9634

SparkiDev wants to merge 1 commit into from

Conversation

@SparkiDev
Copy link
Contributor

@SparkiDev SparkiDev commented Jan 9, 2026 •
edited
Loading

Description

To make 16-byte aligned points, add padding to end.

Testing

./configure --disable-shared --enable-sp --enable-sp-asm --enable-fpecc
./configure --disable-shared --enable-sp --enable-sp-asm --enable-fpecc CFLAGS=-DSP_ALIGN_16

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@SparkiDev SparkiDev self-assigned this Jan 9, 2026
@devin-ai-integration
Copy link
Contributor

devin-ai-integration bot commented Jan 9, 2026

🛟 Devin Lifeguard found 1 likely issues in this PR

  • struct-member-order snippet: Place the 15-byte pad before the 1-byte infinity field (… z[34]; byte pad[15]; byte infinity; …) so that members are ordered from larger to smaller and no larger field follows a smaller one.

@SparkiDev
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@SparkiDev SparkiDev force-pushed the p521_x64_align_16 branch 2 times, most recently from 80815b8 to 48b8d0a Compare January 9, 2026 01:47
@SparkiDev SparkiDev changed the title SP ECC: ecc_point - make infinity a byte and add padding SP ECC: ecc_point - add padding when 16 byte aligned Jan 9, 2026
@SparkiDev
SP ECC: ecc_point - add padding when 16 byte aligned
38e8b94 
To make 16-byte aligned points, add padding to end.
douzzer
douzzer requested changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@douzzer douzzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alas, seeing the same failure as we've seen all along:

[    2.346119] wolfssl: ecc_test_curve(): ecc_test_curve_size 66 failed!
[    2.346878] wolfssl: ecc_test(): keySize=66, Default
[    2.347464] wolfssl: wc_test_render_error_message(): ECC      test failed!
[    2.347464]  error L=33348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@douzzer douzzer douzzer requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@SparkiDev SparkiDev

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SparkiDev @douzzer