Skip to content

refactor: don't return option for dependency_id_to_parents #12609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chenjiahan merged 1 commit into from
Jan 3, 2026
Merged

refactor: don't return option for dependency_id_to_parents #12609

chenjiahan merged 1 commit into from
Jan 3, 2026

Conversation

@hardfist
Copy link
Contributor

@hardfist hardfist commented Jan 3, 2026

Summary

simplify module_graph api to avoid unnecessary option

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings January 3, 2026 13:33
@netlify
Copy link

netlify bot commented Jan 3, 2026 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 203e9a8
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/69591ab1db1f98000881d8df

@github-actions github-actions bot added release: refactor team The issue/pr is created by the member of Rspack. labels Jan 3, 2026
Copilot AI reviewed Jan 3, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR simplifies the ModuleGraph API by removing an unnecessary Option wrapper from the dependency_id_to_parents HashMap, making the type HashMap<DependencyId, DependencyParents> instead of HashMap<DependencyId, Option<DependencyParents>>.

Key changes:

  • Changed the dependency_id_to_parents field type from HashMap<DependencyId, Option<DependencyParents>> to HashMap<DependencyId, DependencyParents>
  • Updated all getter methods to work with the simplified structure, removing unnecessary .as_ref() calls
  • Changed the revocation logic to remove entries instead of inserting None values

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 5 projects with changes.

📊 Quick Summary
Project Total Size Change
react-10k 5.7 MB -
react-1k 825.4 KB -
react-5k 2.7 MB -
rome 984.3 KB -
ui-components 2.1 MB -
📋 Detailed Reports (Click to expand)

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 5.7 MB - -
📄 JavaScript 5.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 825.4 KB - -
📄 JavaScript 825.4 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.7 MB - -
📄 JavaScript 2.7 MB - -
🎨 CSS 21.0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 984.3 KB - -
📄 JavaScript 984.3 KB - -
🎨 CSS 0 B - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

⚠️ No baseline data found - Unable to perform comparison analysis

Metric Current Baseline Change
📊 Total Size 2.1 MB - -
📄 JavaScript 2.0 MB - -
🎨 CSS 83.0 KB - -
🌐 HTML 0 B - -
📁 Other Assets 0 B - -

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

📦 Binary Size-limit

Comparing 203e9a8 to refactor: remove option in dependency_by_id (#12569) by hardfist

🎉 Size decreased by 128bytes from 47.86MB to 47.86MB (⬇️0.00%)

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 3, 2026

CodSpeed Performance Report

Merging #12609 will not alter performance

Comparing yj/refactor-parents (203e9a8) with main (0104f49)1

Summary

✅ 16 untouched
⏩ 1 skipped2

Footnotes

  1. No successful run was found on main (b9e2cc8) during the generation of this report, so 0104f49 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

@chenjiahan chenjiahan merged commit d059e65 into main Jan 3, 2026
61 checks passed
@chenjiahan chenjiahan deleted the yj/refactor-parents branch January 3, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees

No one assigned

Labels

release: refactor team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hardfist @chenjiahan