Skip to content

test: enable passing normalCases tests and document failures #12409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LingyuCoder merged 1 commit into from
Dec 10, 2025
Merged

test: enable passing normalCases tests and document failures #12409

LingyuCoder merged 1 commit into from
Dec 10, 2025

Conversation

@LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Dec 10, 2025

Summary

This PR systematically reviews and processes normalCases test filters without support-related checks:

Enabled Tests (10 test.filter.js removed)

Successfully removed filters for tests that now pass:

  • All 4 statical-dynamic-import related tests in chunks/
  • mjs namespace-object-lazy tests
  • loaders/emit-file test
  • optimize/side-effects-simple-unused test
  • parsing/harmony-destructuring-assignment test
  • parsing/rspack-issue-4816 test (with RegExp variable detection fix)

Documented Failures (5 test.filter.js updated)

Added error documentation for tests that still fail:

  • parsing/issue-758: Missing module warnings cause test failure
  • parsing/precreated-ast: Loader-provided AST not processed correctly
  • resolving/issue-2986: Error message format mismatch
  • loaders/issue-4959: this.loadModule API not implemented
  • errors/load-module-error: this.loadModule API not implemented

Additional Fix

Fixed RegExp variable detection in eval_new_expr.rs to properly handle RegExp shadowing.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings December 10, 2025 09:10
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Dec 10, 2025
@netlify
Copy link

netlify bot commented Dec 10, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 7f2fcab
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/693938f493e2020008d1bc32

@LingyuCoder LingyuCoder enabled auto-merge (squash) December 10, 2025 09:13
Copilot AI reviewed Dec 10, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR systematically reviews and processes normalCases test filters, enabling 10 tests that now pass and documenting failures for 5 tests that still require fixes. The changes align with the goal of improving test coverage and transparency around test failures.

Key changes:

  • Enabled 10 previously filtered tests by removing test.filter.js files
  • Added failure documentation to 5 test.filter.js files that still fail with specific error details
  • Fixed RegExp variable detection in eval_new_expr.rs to properly handle RegExp shadowing scenarios

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/rspack-test/normalCases/chunks/statical-dynamic-import/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/chunks/statical-dynamic-import-then/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/chunks/statical-dynamic-import-then-destructuring/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/chunks/statical-dynamic-import-destructuring/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/mjs/non-mjs-namespace-object-lazy/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/mjs/namespace-object-lazy/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/loaders/emit-file/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/optimize/side-effects-simple-unused/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/parsing/harmony-destructuring-assignment/test.filter.js Removed filter for passing test
tests/rspack-test/normalCases/parsing/rspack-issue-4816/test.filter.js Removed filter for passing test (enabled by RegExp fix)
tests/rspack-test/normalCases/resolving/issue-2986/test.filter.js Added documentation for error message mismatch failure
tests/rspack-test/normalCases/parsing/precreated-ast/test.filter.js Added documentation for loader AST processing failure
tests/rspack-test/normalCases/parsing/issue-758/test.filter.js Added documentation for module warning failure
tests/rspack-test/normalCases/loaders/issue-4959/test.filter.js Added documentation for loadModule API not implemented
tests/rspack-test/normalCases/errors/load-module-error/test.filter.js Added documentation for loadModule API not implemented
crates/rspack_plugin_javascript/src/utils/eval/eval_new_expr.rs Fixed RegExp variable detection to handle shadowing scenarios

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Rsdoctor Bundle Diff Analysis

Found 5 project(s) in monorepo.

📁 react-10k

Path: ../build-tools-performance/cases/react-10k/dist/rsdoctor-data.json

📌 Baseline Commit: 0801df3b7e | PR: #12407

Metric Current Baseline Change
📊 Total Size 5.7 MB 5.7 MB 0 B (0.0%)
📄 JavaScript 5.7 MB 5.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-10k Bundle Diff

📁 react-1k

Path: ../build-tools-performance/cases/react-1k/dist/rsdoctor-data.json

📌 Baseline Commit: 0801df3b7e | PR: #12407

Metric Current Baseline Change
📊 Total Size 823.6 KB 823.6 KB 0 B (0.0%)
📄 JavaScript 823.6 KB 823.6 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-1k Bundle Diff

📁 react-5k

Path: ../build-tools-performance/cases/react-5k/dist/rsdoctor-data.json

📌 Baseline Commit: 0801df3b7e | PR: #12407

Metric Current Baseline Change
📊 Total Size 2.7 MB 2.7 MB 0 B (0.0%)
📄 JavaScript 2.7 MB 2.7 MB 0 B (0.0%)
🎨 CSS 21.0 B 21.0 B 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: react-5k Bundle Diff

📁 rome

Path: ../build-tools-performance/cases/rome/dist/rsdoctor-data.json

📌 Baseline Commit: 0801df3b7e | PR: #12407

Metric Current Baseline Change
📊 Total Size 984.3 KB 984.3 KB 0 B (0.0%)
📄 JavaScript 984.3 KB 984.3 KB 0 B (0.0%)
🎨 CSS 0 B 0 B N/A
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: rome Bundle Diff

📁 ui-components

Path: ../build-tools-performance/cases/ui-components/dist/rsdoctor-data.json

📌 Baseline Commit: 0801df3b7e | PR: #12407

Metric Current Baseline Change
📊 Total Size 2.1 MB 2.1 MB 0 B (0.0%)
📄 JavaScript 2.0 MB 2.0 MB 0 B (0.0%)
🎨 CSS 83.0 KB 83.0 KB 0 B (0.0%)
🌐 HTML 0 B 0 B N/A
📁 Other Assets 0 B 0 B N/A

📦 Download Diff Report: ui-components Bundle Diff

Generated by Rsdoctor GitHub Action

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

📦 Binary Size-limit

Comparing 7f2fcab to fix: improve RuntimeGlobals type definition accuracy (#12403) by harpsealjs

🎉 Size decreased by 640bytes from 47.72MB to 47.71MB (⬇️0.00%)

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 10, 2025

CodSpeed Performance Report

Merging #12409 will not alter performance

Comparing test/enable-normal-cases-tests (7f2fcab) with main (0801df3)

Summary

✅ 17 untouched

@LingyuCoder LingyuCoder requested a review from 9aoy December 10, 2025 09:56
@LingyuCoder LingyuCoder merged commit 9bace5c into main Dec 10, 2025
85 of 87 checks passed
@LingyuCoder LingyuCoder deleted the test/enable-normal-cases-tests branch December 10, 2025 09:57
This was referenced Dec 10, 2025
Merged
Merged
@CPunisher CPunisher mentioned this pull request Dec 17, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@9aoy 9aoy 9aoy approved these changes

Assignees

No one assigned

Labels

team The issue/pr is created by the member of Rspack.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LingyuCoder @9aoy