refactor: split module_graph_mut #12295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
📦 Binary Size-limit
🎉 Size decreased by 640bytes from 47.66MB to 47.66MB (⬇️0.00%) |
Contributor
|
📝 Benchmark detail: Open task failure |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the module graph mutation API by splitting get_module_graph_mut() into two distinct methods: get_make_module_graph_mut() and get_seal_module_graph_mut(). This separation aligns with the compilation lifecycle phases and enables more granular control over module graph access without requiring a mutable reference to the entire Compilation during the make phase.
Key changes:
- Introduced
get_make_module_graph_mut()as a static method that operates onBuildModuleGraphArtifactfor use during make/finish_make/finish_modules phases - Introduced
get_seal_module_graph_mut()as an instance method that operates onseal_module_graph_partialfor use during seal phase hooks (optimize_dependencies, optimize_chunk_modules, etc.) - Renamed
other_module_graphtoseal_module_graph_partialto clarify its purpose
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| crates/rspack_core/src/compilation/mod.rs | Core refactoring: splits get_module_graph_mut() into get_make_module_graph_mut() and get_seal_module_graph_mut(), renames field to seal_module_graph_partial |
| crates/rspack_plugin_rslib/src/import_external.rs | Updates to use get_make_module_graph_mut() for dependency replacement during finish_make hook |
| crates/rspack_plugin_library/src/modern_module_library_plugin.rs | BUG: Incorrectly uses get_seal_module_graph_mut() during finish_make hook |
| crates/rspack_plugin_library/src/export_property_library_plugin.rs | Correctly updates to use get_make_module_graph_mut() during finish_modules hook |
| crates/rspack_plugin_library/src/assign_library_plugin.rs | Correctly updates to use get_make_module_graph_mut() during finish_modules hook |
| crates/rspack_plugin_lazy_compilation/src/plugin.rs | Correctly updates to use get_make_module_graph_mut() during make hook |
| crates/rspack_plugin_javascript/src/plugin/side_effects_flag_plugin.rs | Correctly updates to use get_seal_module_graph_mut() during optimize_dependencies hook |
| crates/rspack_plugin_javascript/src/plugin/module_concatenation_plugin.rs | Correctly updates multiple usages to get_seal_module_graph_mut() during optimize_chunk_modules hook |
| crates/rspack_plugin_javascript/src/plugin/mangle_exports_plugin.rs | Correctly updates to use get_seal_module_graph_mut() during optimize_code_generation hook |
| crates/rspack_plugin_javascript/src/plugin/inline_exports_plugin.rs | Correctly updates to use get_seal_module_graph_mut() during optimize_dependencies hook |
| crates/rspack_plugin_javascript/src/plugin/flag_dependency_usage_plugin.rs | Correctly updates to use get_seal_module_graph_mut() during optimize_dependencies hook |
| crates/rspack_plugin_javascript/src/plugin/flag_dependency_exports_plugin.rs | Correctly updates to use get_make_module_graph_mut() during finish_modules hook |
| crates/rspack_plugin_esm_library/src/plugin.rs | Correctly updates to use get_make_module_graph_mut() during finish_modules hook |
| crates/rspack_plugin_dll/src/flag_all_modules_as_used_plugin.rs | Correctly updates to use get_seal_module_graph_mut() during optimize_dependencies hook |
| crates/rspack_core/src/module_graph/mod.rs | Updates clone_module_attributes() to use get_seal_module_graph_mut() (called during seal phase) |
| crates/rspack_core/src/compilation/build_chunk_graph/new_code_splitter.rs | Correctly updates to use get_seal_module_graph_mut() during chunk graph building in seal phase |
| crates/rspack_core/src/compilation/build_chunk_graph/code_splitter.rs | Correctly updates to use get_seal_module_graph_mut() during chunk graph building in seal phase |
| crates/rspack_core/src/compilation/build_chunk_graph/artifact.rs | Correctly updates to use get_seal_module_graph_mut() during chunk graph building in seal phase |
| crates/rspack_binding_api/src/exports_info.rs | Updates to use get_make_module_graph_mut() for JS binding API access |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crates/rspack_plugin_library/src/modern_module_library_plugin.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
stormslowly
previously approved these changes
Nov 26, 2025
CodSpeed Performance ReportMerging #12295 will degrade performances by 11.5%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
this is expected since ModuleGraph performance regression casued by adding another seal_module_graph_partial https://github.com/web-infra-dev/rspack/pull/12295/files#diff-49667efb7ffa54ffd58f91bc842dc73e9be1e6c901e1638a47e4f2292c16d822R178 |
stormslowly
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
split module_graph_mut into get_make_module_graph_mut and get_ seal_module_graph
so we don't need to hold &mut Compilation for make_module_graph
Related links
Checklist