fix: buildDependency resolver add more file extensions #12260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rspack canceled.
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the buildDependency resolver in rspack's persistent cache system by adding support for commonly used file extensions (.js, .ts, .mjs, .cjs, .json, .node). This allows the build dependency tracking system to properly resolve dependencies with these extensions, which is essential for accurate cache invalidation.
Key changes:
- Adds a new
extensionsconfiguration to the resolver with 6 file types - Updates test suite to validate resolution of the newly supported extensions
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crates/rspack_core/src/cache/persistent/build_dependencies/helper/mod.rs
Show resolved
Hide resolved
Contributor
📦 Binary Size-limit
❌ Size increased by 512bytes from 47.63MB to 47.63MB (⬆️0.00%) |
CodSpeed Performance ReportMerging #12260 will not alter performanceComparing Summary
|
LingyuCoder
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The buildDependency resolver should support some commonly used file extensions in the rspack configuration.
This PR will add
.js,.ts,.mjs,.cjs,.json,.nodeextensions for buildDependency resolverRelated links
Checklist