Implementing callbook failover logic #2665
Merged
+36
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Before we are going to check this PR: Really well done Pull Request! Simple, Short, Single Feature, Necessary Changes only Really Really good! |
phl0
requested changes
Dec 10, 2025
Co-authored-by: Florian (DF2ET) <github@florian-wolters.de>
Contributor
Author
|
@phl0 I implemented your suggestions |
Contributor
Seen that. Will re-check. |
phl0
approved these changes
Dec 12, 2025
Contributor
phl0
left a comment
There was a problem hiding this comment.
This works for me. We should put an example and some description into config.sample.php (if not in this PR I can add it separately).
Contributor
Author
|
@phl0 ok, I will update the wiki later tonight |
AndreasK79
approved these changes
Dec 13, 2025
Contributor
|
Tested working here :) |
Contributor
Author
|
I started documenting the config file, with some notes on this feature: Config.php |
Contributor
And I added some description to config.sample.php 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR implements a very simple callbook failover logic.
Summary
$config['callbook']is set to a single string (default), nothing is changed in the logic, a single query is performed and result is evaluated accordingly$config['callbook']is set to an array, then the different providers are sequentially tested to see if a valid response is returnedTesting
I tested the following scenarios:
Back compatibility
I let the default
config.phpconfig (or with any single providers set):And the following sequence was returned (single callbook -> single request). The single provider was tested, nothing different from existing behavior.
New behavior
I set the
config.phpconfig to an array of providers, and the following sequence was returned (providers are tested in the same sequence as defined in the config):