Skip to content

Fixed wrong current directory while creating a new Bookmark #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed wrong current directory while creating a new Bookmark #168

wants to merge 2 commits into from

Conversation

@ganlub
Copy link

@ganlub ganlub commented Feb 24, 2016

The first time I added a Bookmark (<a>) everything went well. But the following I added took the directory of the "visually selected one" instead of its own.

screenshot from 2016-02-25 00-03-13

@ganlub
Copy link
Author

ganlub commented Feb 25, 2016

On :help ctrlspace section 5.5, it says to press <a> to add a new Bookmark but on the Key Reference there's <a> and <A> to "Add a new bookmark (A - with CWD)". Using <A> works good, but if I use <a>, it happens what I posted on my previous comment.

@Konfekt Konfekt mentioned this pull request May 15, 2016
Open
@jyscao jyscao added bug: misbehavior minor annoyances, not workflow disruptions enhancement: tweak & config augment existing features, behaviors & configurations priority: 2 - low labels Nov 10, 2020
@jyscao
Copy link
Collaborator

jyscao commented Nov 10, 2020

@Konfekt do you know if this PR is still relevant (it dates back to 2016...)?

@Konfekt
Copy link
Collaborator

Konfekt commented Nov 10, 2020

Yes, It is. Indeed a proposed to add the selected bookmarked directory which is pointless.

@Konfekt
Copy link
Collaborator

Konfekt commented Apr 13, 2022

@jyscao : This looks good to go as I see little benefit in adding the selected already added bookmark.

@ganlub : Would you mind syncing to master to resolve conflicts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug: misbehavior minor annoyances, not workflow disruptions enhancement: tweak & config augment existing features, behaviors & configurations priority: 2 - low

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ganlub @jyscao @Konfekt