feat(isPassportNumber): add Norwegian passport validation #2623
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2623 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2566 2566
Branches 651 651
=========================================
Hits 2566 2566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
The regex is constructed based on the Norwegian Police's control guide: https://www.politiet.no/globalassets/tjenester-admin/pass-og-id-kort/control-guide-for-norwegian-passports.pdf (ISBN 978-82-8256-097-9). It matches Norwegian passport numbers starting with C, K, or FG, FH, FJ, FL, and FK prefixes, followed by alphanumeric characters. The guide is not very detailed. It does not specify passport number length, so this is not validated.
2c5b8d5 to
0b532a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex is constructed based on the Norwegian Police's control
guide: https://www.politiet.no/globalassets/tjenester-admin/pass-og-id-kort/control-guide-for-norwegian-passports.pdf (ISBN 978-82-8256-097-9).
It matches Norwegian passport numbers starting with C, K, or FG, FH, FJ, FL, and FK prefixes, followed by alphanumeric characters.
The guide is not very detailed. It does not specify passport number length, so this is not validated.
Checklist
control-guide-for-norwegian-passports.pdf