fix(isLength): correctly handle Unicode variation selectors #2616
+145
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WikiRik
reviewed
Nov 5, 2025
Member
WikiRik
left a comment
There was a problem hiding this comment.
Thanks for opening this PR! Can you move the existing isLength tests to the new file as well? And rebase upon the master branch so CI passes?
d610902 to
0568fb7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2616 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2566 2566
Branches 651 651
=========================================
Hits 2566 2566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WikiRik
approved these changes
Nov 5, 2025
rubiin
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the validator would subtract all Unicode variation selectors (
\uFE0F,\uFE0E) from a string's total length. This allowed for a string to contain a potentially infinite number of these characters while still passing a max length validation. For example, a string like "test\uFE0F\uFE0F\uFE0F..." could easily bypass a max: 4 check.Variation selectors are now only discounted from the length if they directly follow a base character they are modifying. If they appear at the start of a string or in a sequence, they are correctly counted towards the total length.
References:
Checklist